hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
835 stars 110 forks source link

Funimation Issues #373

Closed hama3254 closed 3 years ago

hama3254 commented 3 years ago

I made a view fixes for funimation with Crunchyroll-Downloader-Chromium-U5 it should work now, if not this is the place to comment your specific issue. grafik

pruebark9 commented 3 years ago

Thanks for your work but the problem continues. Now I get this but my account is active and I can see the chapter I am trying to download without any problem.

---------------------------
No media
---------------------------
No media found in:

{"errors": [{"code": 4, "detail": "No valid Free Avails for this experience", "title": "No avails"}]}
---------------------------
hama3254 commented 3 years ago

This is normal to happen if you are not logged in inside the build-in web-browser, a similar issue is the "mature content" filter: grafik

This is also the only way for me to test that the account gets used properly since i have no premium account but mature content is accessible in my tests. grafik

pruebark9 commented 3 years ago

Holy!!!

Yes, now it works. The strange thing is that when I entered the browser inside the program it appeared to me as logged in. Now I opened it as administrator and it came up to log me in. I logged in and now it works.

Thank you very much!

PS: The chrome extension to add several chapters at once does not work anymore?

acteias commented 3 years ago

Hello, there are some bugs in the new version, downloading with Funimation equal to CR only to use one season at a time and then you have to close the program and open it again to be able to download another anime, otherwise you'll be downloading the same anime infinitely other than the sometimes it doesn't create a folder, but what I really wanted was to have something to fix the crashing of the video and audio of animes downloaded from CR only happens with animes downloaded from there, the ones from funimation have perfect audio and video without crashing or anything, but from CR has an episode that crashes. can you help me?

acteias commented 3 years ago

https://user-images.githubusercontent.com/16007846/137420292-1059aa13-b4d7-47cc-b983-d6187a4715cd.mp4

hama3254 commented 3 years ago

one season at a time and then you have to close the program and open it again to be able to download another anime, otherwise you'll be downloading the same anime infinitely

That interesting but seems a smaller issue since everything except the end urls work fine, i see what I can do there.

the crashing of the video and audio of animes downloaded from CR only happens with animes downloaded from there, the ones from funimation have perfect audio and video without crashing or anything, but from CR has an episode that crashes.

Are you using the hybrid mode ? that the only difference in the downloade i can think of since Funimation uses v4 m3u8 files with crunchyroll uses v5 or v3 which needs different code to process.

@pruebark9

PS: The chrome extension to add several chapters at once does not work anymore?

I didn't test it for a while now, i take a look at it later

acteias commented 3 years ago

I don't use hybrid mode is it better than normal?

acteias commented 3 years ago

image from what I'm understanding the hybrid mode downloads twice?

hama3254 commented 3 years ago

from what I'm understanding the hybrid mode downloads twice?

the hybrid mode is designed to cache the data from the stream directly with multiple threads to improve the download speed. You have the option to keep those files after the video files has been created. grafik

acteias commented 3 years ago

I understand, so it doesn't work for me my internet is 800mb I download very fast in normal mode

hama3254 commented 3 years ago

I understand, so it doesn't work for me my internet is 800mb I download very fast in normal mode

That would be unusual, the normal download is done by ffmpeg and is single threaded which means you should never get to use your internet speed fully. For me as example i get ~500 Mbit\s a normal ffmpeg download takes about 5 minutes while a hybrid mode download only takes a little over 1 minute completely with downloading an combining (no re-encoding). This will vary based the hardware and settings.

crashing of the video and audio of animes downloaded from CR

If this is not caused by the hybrid mode then i can take a look at the logfile but i don't think i can do much there since the download gets handled by ffmpeg.

you can get the logfile from the right click menu and then either saving it or copying it to the clipboard

grafik

acteias commented 3 years ago

log.txt in hybrid mode i had no problem with image freeze in at least two episodes i watched

acteias commented 3 years ago

log to complete.txt

pruebark9 commented 3 years ago

I've seen that there was a new version of the extension for Chrome and in Crunchyroll it works, but in Funimation it didn't add the bookmarked episodes.

hama3254 commented 3 years ago

if fail to see any issue there, did you get any kind of error? grafik

Serpentstar commented 3 years ago

Is there an updated application (Non browser) version? The last release is from April and it keeps locking up during downloads. I attempted the get files version and running the binary but it hard crashes out.

hama3254 commented 3 years ago

Is there an updated application (Non browser) version? The last release is from April and it keeps locking up during downloads. I attempted the get files version and running the binary but it hard crashes out.

The last released version is Crunchyroll-Downloader-Chromium-U5 other version are not updated anymore. if you have issues with this version i need a report what's not working.

Serpentstar commented 3 years ago

I will just have to deal with the issues on the old version. I tried the one you pointed me to and the moment I try to do a download, the program tries to connect to China IP 42.250.217.131which my local network has GeoIP blocked. The older version didn't do that. Thanks.

Serpentstar commented 3 years ago

found a different issue. One of my other security endpoint applications is causing an issue. Will keep looking at it. Thanks for your program. I think it is pretty damned cool.

pruebark9 commented 3 years ago

I have tried again and the chrome plugin is working.

I don't know what you have done but this is the best version I have used so far, the hybrid mode downloads faster than before and I always had it enabled.

And the Crunchyroll download starts in less than 5 seconds of adding the link, before it took up to 10.

And in Funimation I had to try at least 5 times to start the download, now it does it the first time. It takes 10-15 seconds for no matter what, the good thing is that it starts it.

The only error that I see that is still present is that in Funimation, I have set the dub language as Spanish, before when I downloaded a chapter that did not have dubbing, it automatically downloaded the Japanese version. Now for some time, if it doesn't have Dub, it comes out a message saying that it hasn't found the dub and it doesn't do anything else.

Thank you very much for your work.

Translated with www.DeepL.com/Translator (free version)

pruebark9 commented 3 years ago

I have tried again and the chrome plugin is working.

I don't know what you have done but this is the best version I have used so far, the hybrid mode downloads faster than before and I always had it enabled.

And the Crunchyroll download starts in less than 5 seconds of adding the link, before it took up to 10.

And in Funimation I had to try at least 5 times to start the download, now it does it the first time. It takes 10-15 seconds for no matter what, the good thing is that it starts it.

The only error that I see that is still present is that in Funimation, I have set the dub language as Spanish, before when I downloaded a chapter that did not have dubbing, it automatically downloaded the Japanese version. Now for some time, if it doesn't have Dub, it comes out a message saying that it hasn't found the dub and it doesn't do anything else.

Thank you very much for your work.

hama3254 commented 3 years ago

the moment I try to do a download, the program tries to connect to China IP 42.250.217.131which my local network has GeoIP blocked.

The downloader loads the website you want to download from like a normal webbrowser and then process the data it finds during loading or inside the HTML of the website. I have no influence what you try to access or what some websites use in the background.

I don't know what you have done but this is the best version I have used so far, the hybrid mode downloads faster than before and I always had it enabled.

And the Crunchyroll download starts in less than 5 seconds of adding the link, before it took up to 10.

That sounds more like either your internet has become faster or your computer has, the normal crunchyroll website needs to load then i have all data i need so if the websites load a view seconds faster the downloader can start the processing sooner.

For the hybrid mode i use the PCs logical processors for a baseline of threads i can run at once per download so better computer might increase the speed if the network can handle that.

And in Funimation I had to try at least 5 times to start the download, now it does it the first time.

That was my greatest issue, something that works sometimes and sometimes not is hard to fix since if you look for an error it does not happen...

It takes 10-15 seconds for no matter what, the good thing is that it starts it.

That normal since i need to make sure that the video had time to load before i can see if i got something inside the network traffic.

NatsuFT36 commented 3 years ago

In the chapters, for example of Mieruko-chan when I download it in the Japanese language, in the information I get that the language is in English and the dubbing has not yet debuted and they barely go in episode 3.

image ![Captura de pantalla (21)](https://user-images.githubusercontent.com/51544427/137633763-063f130f-e552-4805-8ef9-72aa0c2f76aa.png)
hama3254 commented 3 years ago

In the chapters, for example of Mieruko-chan when I download it in the Japanese language, in the information I get that the language is in English and the dubbing has not yet debuted and they barely go in episode 3.

Simply said it defaults to English for the metadata, this is because i seem to not used the new values for that part. This was easy to fix i just needed to change the values.

image ![grafik](https://user-images.githubusercontent.com/52826614/137637214-8e5f8709-1c4b-4b1a-9b84-af3d07c85205.png)

this is just a very minor issue so i don't upload a real release for that but if you want it to be the right metadata you can get the latest Crunchyroll Downloader.exe here

NatsuFT36 commented 3 years ago

It would be good if I added Chinese language since Chinese series appear on Funimation such as Link Click and Ancient Girl's Frame

619beave commented 3 years ago

Found another issue. So far, it is only this anime episode so far. https://www.funimation.com/v/tesla-note/a-consideration-on-mission-is

The Anime completes both the Video Stream and the Audio Stream, but is unable to put the 2 streams together at the end.

The filename will be Tesla Note Season 1 Episode 3 A Consideration on Mission IS.mp4. But the title of the episode is A Consideration on "Mission IS" on Funimation.

Screenshot 2021-10-17 14 42 42 Fuimation error-20211017.txt

hama3254 commented 3 years ago

It would be good if I added Chinese language since Chinese series appear on Funimation such as Link Click and Ancient Girl's Frame

You probably can not even download that, the dub setting defaults to Japanese as value and I have no proper error Handling yet...

hama3254 commented 3 years ago

Found another issue. So far, it is only this anime episode so far. https://www.funimation.com/v/tesla-note/a-consideration-on-mission-is

The Anime completes both the Video Stream and the Audio Stream, but is unable to put the 2 streams together at the end.

The filename will be Tesla Note Season 1 Episode 3 A Consideration on Mission IS.mp4. But the title of the episode is A Consideration on "Mission IS" on Funimation.

Screenshot 2021-10-17 14 42 42 Fuimation error-20211017.txt

For that i would need the processing log which you get with a right click and then either copying it to the clipboard or save it to a file.

619beave commented 3 years ago

Screenshot 2021-10-18 09 48 43

Log at CR Downloader Error-20211018-0949.txt

hama3254 commented 3 years ago

now i see the issue, it's just the file name with the " which should not be inside the name. the fix is online as Crunchyroll-Downloader-Chromium-U6

619beave commented 3 years ago

Thanks,

The Episode now is working.

Thanks again for the great work on this program.

pruebark9 commented 3 years ago

After a week of working fine, now this error is back again. The funny thing is that it only happens with the new anime with dubbing that Funimation releases every Thursday.


Crunchyroll Downloader

System.ArgumentException: Caracteres no válidos en la ruta de acceso.

en System.Security.Permissions.FileIOPermission.EmulateFileIOPermissionChecks(String fullPath)

en System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)

en System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)

en System.IO.StreamWriter.CreateFile(String path, Boolean append, Boolean checkHost)

en System.IO.StreamWriter..ctor(String path, Boolean append, Encoding encoding, Int32 bufferSize, Boolean checkHost)

en System.IO.File.InternalWriteAllText(String path, String contents, Encoding encoding, Boolean checkHost)

en Crunchyroll_Downloader.Main.GetFunimationJS_Video(String v1JsonUrl, String v1JsonData) en D:\Projecte\Crunchyroll Downloader - v3.0-final\Crunchyroll-Downloader-v3.0 - CefSharp\Crunchyroll Downloader\Main.vb:línea 5709

Aceptar

Edit: like old times, after more than 5 attempts finally started downloading :p

pruebark9 commented 3 years ago

I finally upgraded to the U6 and it works without any problem. I hadn't noticed that another update had already been released. Thanks!

bybpow commented 3 years ago

Hi.

I just downloaded the sixth update and Funimation is working but know I do have a question with the new Funimation player change etc. I downloaded Arifureta just fine but the series has both simulcast and uncut, so my question is: How can I know which version has been downloaded?

Thanks in advance.

hama3254 commented 3 years ago

Hi.

I just downloaded the sixth update and Funimation is working but know I do have a question with the new Funimation player change etc. I downloaded Arifureta just fine but the series has both simulcast and uncut, so my question is: How can I know which version has been downloaded?

Thanks in advance.

is most likely the simulcast version since the downloader takes the first match for the Dub language and as far i can see they list simulcast first. grafik

it might be possible to implement a selection for that but currently my internet is down since a view days and my mobile data is not only slow but also limited which makes downloading of multiple gigabytes for testing not the best idea.

It does not become simpler that the part of the code where i need to select the version is not final yet since i have no error handling if the dub you selected in the settings is not found and disabling the dub in the settings will get just japanese as default value anyway so i would need a solution for that first.

and last but not least the uncut version is behind the paywall and since i'm still from central Europe i don't need a subscription since i don't use the service myself because Wakanim has most of the shows here.

grafik

acteias commented 3 years ago

I would like to know if I can add a frame rate and Audio limit

bybpow commented 3 years ago

@janilssonn What do you want that for? In AV standard framerate is 24fps.

bybpow commented 3 years ago

@hama3254 Thanks for the reply. Do whatever you want whenever you want. I mean, don't get my comment as something like "do this". I don't know if I'm explaining myself. Wakanim isnt' available in my country so I usually use Funimation to get the exclusive shows that neither Hidive nor Crunchyroll have using a VPN. I also think that getting the Japanese dub as default is the best option. I don't watch dub. I said this other times but if you need access to a premium account I have no problem sharing mine or getting you one for testing. If you could implement in the future the option to get simulcast or uncut would be fantastic. Thank you for your time.

acteias commented 3 years ago

@bybpow sorry I expressed myself wrong, it's the bit rate

hama3254 commented 3 years ago

Do whatever you want whenever you want.

I already do what I want, it's only a problem if I don't know how to handle some things.

I said this other times but if you need access to a premium account I have no problem sharing mine or getting you one for testing.

If you could give me access to your account it would be helpful (at least whenever I get internet again...) If you want you can DM me on discord Hama#4155

hama3254 commented 3 years ago

I would like to know if I can add a frame rate and Audio limit

@bybpow sorry I expressed myself wrong, it's the bit rate

Just to be clear, does that mean you want to change the output file (which is already possible but not recommend for inexperienced user) or a selection for the High/Low Bitrate versions of the video?

bybpow commented 3 years ago

@hama3254 i just send you a discord request. accept me whenever you can and ill send you the keys. my username is the same there.

hama3254 commented 3 years ago

@bybpow i did not get any friend request or message as far i can see.

acteias commented 3 years ago

@hama3254 Yes, when I download the videos I convert to 1524kbps but I have problems with some videos using Movavi Video Converter premiun, the videos are not synchronized so I have to use another program to do this and then use Movavi to edit, I just wanted a track that gives to put the amount of kbps you want to download if possible, of course! thank you so much for answering

acteias commented 3 years ago

@hama3254 this sync error only in Crunchyroll's videos and Funimation's is normal on Movavi

acteias commented 3 years ago

@hama3254 This error happens sometimes even if I don't change the bitrate and it only happens on Crunchyroll videos, with that I have to test all the videos I download and download again if it's freezing.

hama3254 commented 3 years ago

@janilssonn it is interesting that CR videos have that issue, it would make a lot more sense the other way around since on CR there is a complete stream with audio and video while on Funimation i have two streams which i need to combine.

[Warning] the following can crash the download due to invalid settings, there are no checks or tests in place! Please try the options only without the hybrid mode this will make the download fail before you completely download the episode. You can use the hybrid mode if you found your settings working.

You can already set a re-encoding option inside the output tab of the settings, you just need to use one of the encoder other than copy then you can set the Bitrate from 1000k to 7000k (only in 1000 steps). This will download the same video but converts it. If you have a somewhat recent Nvidia graphics card than the nvenc options would be a good choice.

acteias commented 3 years ago

@hama3254 Thanks, I will test and yes my video card is new, that's why I kept telling you to fix the Funimation download because I have this problem in CR and I never use the Hibrido download because it makes me download two times always!

acteias commented 3 years ago

image

acteias commented 3 years ago

please add the option -b:v 1500k and 24 frame rate if it's not too much, I've tested it and found it wonderful but it's 30fps