hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
844 stars 108 forks source link

Crunchyroll-Downloader-v3.9_Indev #553

Closed hama3254 closed 1 year ago

hama3254 commented 1 year ago

Crunchyroll-Downloader-v3.9_Indev_U2 is now available!

pruebark9 commented 1 year ago

It does not work for me, I am logged in and running as admin and I always get this error:


Crunchyroll Downloader

Newtonsoft.Json.JsonReaderException: Error reading JObject from JsonReader. Path '', line 0, position 0.

in Newtonsoft.Json.Linq.JObject.Load(JsonReader reader, JsonLoadSettings settings)

in Newtonsoft.Json.Linq.JObject.Parse(String json, JsonLoadSettings settings)

in Crunchyroll_Downloader.Main.GetBetaVideo(String Streams, String WebsiteURL) in D:\Project Crunchyroll Downloader - v3.0-finalCrunchyroll-Downloader-v3.0 - CefSharp\Crunchyroll Downloader.vb:line 1252

Accept

But the first version you released does work for me, after trying so hard the login worked and it works :D

Serpentstar commented 1 year ago

I tried to set the output to hybrid mode and it caused an Unhandled Exception error.

image

** Exception Text ** System.NullReferenceException: Object reference not set to an instance of an object. at Crunchyroll_Downloader.Einstellungen.Btn_Save_Click(Object sender, EventArgs e) in D:\Projecte\Crunchyroll Downloader - v3.0-final\Crunchyroll-Downloader-v3.0 - CefSharp\Crunchyroll Downloader\einstellungen.vb:line 488 at System.Windows.Forms.Control.OnClick(EventArgs e) at System.Windows.Forms.Button.OnClick(EventArgs e) at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent) at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ButtonBase.WndProc(Message& m) at System.Windows.Forms.Button.WndProc(Message& m) at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Why do you have D: hard coded here? I haven't went further than this yet.

ghost commented 1 year ago

it works for me

but everything is extremely slow. the scan for the links and the download itself.

I also noticed that the font has changed? image

but i must also note that i did not use yesterday's version. perhaps all those who have problems with it should delete everything completely.

Serpentstar commented 1 year ago

Just bringing up the program and without clicking on anything, we have errors about a locale pak for en-US

[1021/125316.869:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.869:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.869:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.869:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.869:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.869:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.870:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125316.870:WARNING:resource_bundle.cc(1161)] locale resources are not loaded [1021/125317.026:WARNING:resource_bundle.cc(448)] locale_file_path.empty() for locale [1021/125317.026:ERROR:alloy_main_delegate.cc(535)] Could not load locale pak for en-US [1021/125317.391:WARNING:resource_bundle.cc(448)] locale_file_path.empty() for locale [1021/125317.392:ERROR:alloy_main_delegate.cc(535)] Could not load locale pak for en-US

@xILikepuddingx Look at your browser log. I think there is a rejection going on for FontAwesome would could be playing a part in the fonts.

Serpentstar commented 1 year ago

I am still getting stuck at the URL1 part. The browser logs are showing a lot of Refused to connect, refused to load, and Cant display the consent link. browser.log

hama3254 commented 1 year ago

I tried to set the output to hybrid mode and it caused an Unhandled Exception error.

@Serpentstar i did not even do something to the settings since #543 and i also don't get any issues.

The line indicated in your log would also be this option not the download mode so i have no idea whats going on there. grafik

Serpentstar commented 1 year ago

I deleted everything this time, including the contents of the old folder where everything was saved, and the registry entries again. That seems to have resolved the saving issue, but not becoming stuck at URL1.

I made some progress and then failed. I clicked on the cookie option and chose opt out and it took me to a blank selection page. I hit cancel and it took me back to the Url1 stop. browser.log

Probably unrelated, but should the Crunchyroll-Downloader-v3.9_Indev_U2\lib\locales folder be empty? That is likely why I am getting the 'Could not load locale pak for en-US.' error

nekudah commented 1 year ago

Need to login everytime on launch, besides that, all working like always has.

petenun commented 1 year ago

Unfortunately 3.9 U2 is not working for me, in fact I'm seeing the same behavior as before. I tried running as both current user and administrator with the same results. In both instances I re-logged-in via the integrated browser with every launch, but it still counts down to URL1 and stops, never giving the option to select season or episodes. I tried rebooting in case there were any leftovers from U1 but that didn't help.

Serpentstar commented 1 year ago

Perhaps this is something Geo related? @nekudah and @petenun, Where are you at country wise? I am in the US.

petenun commented 1 year ago

I am also in the US - Seattle area, specifically.

After my last post, I waited about 15 minutes at the URL1 and finally got a "Select Stream" prompt or either audio or video, which I haven't seen before. Even in the prompt, though you can select a stream, no other drop-down options are available. Screenshot attached.

3 9U2_SelectStream

cimmy01 commented 1 year ago

I too am experiencing the same behavior sometimes I can get it to work if I close out and relog in and it will download a handful of episodes some of the time. I tried erasing the program from its folder and unzip it again and that has worked about the same as reloading. When it works it is working but it is very inconstant.

petenun commented 1 year ago

I tried re-downloading, clearing reg entries, and removing old config data, but have only gotten past the URL1 stall one time out of over 20 attempts.

Serpentstar commented 1 year ago

Lets let @hama3254 keep looking at it, there was something that changed post the actual 3.8.9 release. The reason it probably wasn't noticed more is because anyone who was working had no real reason to upgrade, thus less exposure. That is what I was doing until CR changed their page.

petenun commented 1 year ago

Agreed, @Serpentstar. @hama3254 knows what they're doing, and we don't want to push or get in the way.

CavemanTechandGamming commented 1 year ago

It seems like for me it's working one in every five tries and when it actually works the browser only loads the HTML code and shows that not the actual website.

nekudah commented 1 year ago

I think you guys got the wrong idea what a github is xD. We are sharing issues to help the devs, that's the idea of this thread. No one here is rushing or demanding nothing :) !

Serpentstar commented 1 year ago

@nekudah. Yup, I fully agree. That is why I am not asking for features or time frames, I have just provided a reference point on when something caused a adverse change in behavior. I am providing the actions I am going through to reproduce the issue, and I am providing whatever logs I can find to provide insight into what could be causing the adverse behavior. That is what anyone in QA would do, isn't it?

So far, we have 2 users of the software which are in the US encountering similar behavior. Without sufficient sampling and understanding of why an action is occurring, it would be challenging to resolve it.

You said you have to relog each time. I can say I have the same. This suggests that a login token or session cookie may be being presented that gets wiped when the application is closed. This is a change on the side of CR.

Since it mostly works for you, are you in the US? If you are, then it likely removes the Geo relation aspect. If not, then that adds an additional bit of information.

petenun commented 1 year ago

I'm an infrastructure specialist, not a dev type, but I think our goals are the same - providing @hama3254 with gathered information and test scenarios that may be helpful in troubleshooting. I agree that geo location would be a good datapoint to gather.

I'm in the process of setting up a clean Windows 10 21H2 VM for further "virgin" testing. My thinking is that it might be useful in isolating outside variables.

pruebark9 commented 1 year ago

Now the subtitles come inside the mkv, don't they? It no longer downloads them separately.

ghost commented 1 year ago

So

every now and then i have the same problem with the one second. but then i press download again and most of the time it works.

then just I had also 2x an error. the first time I have missed to make a screenshot of it. the second time I have thought of it. the first error was different.

image

hama3254 commented 1 year ago

i start with my biggest question, how did you get that selection screen?

3 9U2_SelectStream

it should not open for crunchyroll since it is not required (and does therefore not work)

The code is a mess right now but it does not happen to me at all. https://user-images.githubusercontent.com/52826614/197331883-166fb4ff-eafe-4869-8ef2-7d5d556a0fff.mp4

and i tried a full season with any issues ![test](https://user-images.githubusercontent.com/52826614/197331983-d8c145af-9f0d-4773-818e-6a1f364a27e0.png)
hama3254 commented 1 year ago

Now the subtitles come inside the mkv, don't they? It no longer downloads them separately.

@pruebark9 there may be some issues with the settings, please check if your merge setting is like you want. [merge disabled] should give you the subtiles as there own files

grafik

Isaias-Barbosa commented 1 year ago

Why does this happen? ![Uploading Screenshot_20221022-064315.png…]()

hama3254 commented 1 year ago

@Isaias-Barbosa the screenshot did not finish uploading, please try it again.

hama3254 commented 1 year ago

Crunchyroll-Downloader-v3.9_Indev_U3 is now available!

ghost commented 1 year ago

loading times are better and the fonts has been fixed :D The version before already worked well with a few small exceptions. the error I had, unfortunately did not always come and is not reproducible^^

should something happen again, I'll get back to you =)

a big thank you^^

pruebark9 commented 1 year ago

Now the subtitles come inside the mkv, don't they? It no longer downloads them separately.

@pruebark9 there may be some issues with the settings, please check if your merge setting is like you want. [merge disabled] should give you the subtiles as there own files

grafik

Yes, that was it, thank you very much!

cimmy01 commented 1 year ago

I've tried it on a few shows this morning with mixed success some of the shows worked with no issues extremely fast, i.e. my hero episode 117, welcome to demon school, mob psycho 3 episode 3 English dub. One hangs at the processing URL 1, .i.e. My-Otome. Lastly I've had two that have crashed the program in the middle of a muli episode download that successfully started i.e. My Hime, Mongolian chop squad English dub, world witches take off English dub. After restarting the program it will hang at the Processing URL 1 but was able to get another episode to download successfully it was somthing I had previously downloaded successfully earlier. I am attaching the browser.log and a screen shot since I have nothing else to give. browser.log Screenshot 2022-10-22 084733

cimmy01 commented 1 year ago

Update I played with it some more to see if I can get a consistent result. So far I think I have When trying a couple different shows just eliminate a problem with the show at the website level, i.e. Blassriter and mob psycho it will download 3 episodes and hang on the 4th. The program is completely unresponsive but is very occasionally making network and cpu calls according to task manager. Once I restart it it will finish downloading the cached episodes without requiring a login I then have to login before it let me download another 3 episodes and hand on the 4th.

ms-ku commented 1 year ago

Hello Hama

At first, thank you for your work and time!!!

In my case the download with Version U3 is now working! But saving of the login data and changed settings still does not work! I tested it in a fresh Windows 10 (21h2 + C++ v14.32.31332) - the login data problem persist here also but the saving of changed settings works! Is there another location where the Downloader save any settings? I deleted the Profile Folder but this was not the solution.

Thanks and greetings msku

grafik

pruebark9 commented 1 year ago

I have tried V3 and it still doesn't work, it always gives me an error when starting the download. Luckily, V1 works without any problem.

petenun commented 1 year ago

@hama3254

i start with my biggest question, how did you get that selection screen?

it should not open for crunchyroll since it is not required (and does therefore not work)

The code is a mess right now but it does not happen to me at all. https://user-> and i tried a full season with any issues

I honestly don't know how I got that "select stream" prompt. It just popped up once or twice.

As for U3, it looks like you've made significant progress. I have now been able to download specific episodes, one at a time. However, it still freezes at "URL 1" when I try to download a season. (Vid clip attached). Subtitles were properly imbedded in the mkv file though.

https://user-images.githubusercontent.com/55004359/197349800-9d65c260-1c06-423f-9dbc-baa7bcca9f6e.mp4

Isaias-Barbosa commented 1 year ago

@Isaias-Barbosa the screenshot did not finish uploading, please try it again.

Screenshot_20221022-064315

Serpentstar commented 1 year ago

I can concur with @petenun. I was able to download a single episode of Spy X Family, but only after i selected the specific episode from the web page. I was not afforded the option of choosing an entry from the series.

I did discover that I had more config files in places I didn't expect them, including the downloads folder although the one part I am concerned with is that you have the svchost.exe process calling on a non executable, Crunchyroll Downloader.exe.config. This didn't happen prior to Snapshot. This triggered an anomaly on my AV.

I am going to go on a snipe hunt and remove all the CR files from the system and the registry again to see if addresses the series issue, unless this is still known to not work.

For the odd screen that @petenum reached. I had the same thing after I clicked ok on the cookies option and then selected to not accept them. (I think) But that was yesterday.

Isaias-Barbosa commented 1 year ago

I'm not able to log in

image

petenun commented 1 year ago

I also got this when I was testing, though I tracked it down to being logged-in too many times and from too many instances (multiple browsers on multiple PCs). I logged-out of all instances, waited 5 minutes, and then it let me back in.

bybpow commented 1 year ago

I just downloaded the U3 iteration. It keeps crushing. How can I clean the registry to do a fresh "installation"? Also in U2, after 15 downloads or so the program freezes with "Processing" but doing nothing else.

Serpentstar commented 1 year ago

@bybpow If you have never played with the registry, I HIGHLY recommend you watch a few videos on it first. One wrong deletion and it can brick your system. The scare tactic is intended here.

If you are even the slightest bit nervous, don't do it. Plain and simple. It will be a bad day for you if you delete the wrong key. Once you have an understanding of it, as well as panel navigation, make a full backup and do not skip that step.
First and foremost, go slow. Those oops actions are avoidable and you don't want them. Second, do not touch any entry that discusses environment. I didn't have any, but one never knows. You can first search for the word Crunchy. You will find quite a few entries. Some you will remove the entry, others you will remove the whole key. Once done there, do a search for CRD. Again, go very slow.

Go download a program that allows for decent searching of your drive that does not do indexing. Pick your poison here. Search first for the word Crunchy. Look at the folder and it if looks like it belongs to this program, delete it. Once done with that, look for CRD. Do the same.

If you have never performed this type of surgery on your system, don't start here. Instead find someone to assist you locally. It is far to easy to completely kill your computer by deleting the wrong file.

I am still having the processing issue myself, so I would recommending patiently waiting until @hama3254 finishes ironing out the new kinks that CR introduced. It wasn't his fault that CR screwed this all up for the rest of us.

There is no warranty here. You asked how to do it, I just shared my experience with you with some suggestions. Don't do it if you don't have another system to work with. Good luck.

bybpow commented 1 year ago

@Serpentstar Thanks for the info. I'll just wait then. I just wanted to report my experience but as I read people cleaning the Registry I thought maybe I have some leftovers from the previous version. Again, thanks for the reply.

petenun commented 1 year ago

If it makes you feel any better, I don't think anyone has had any success from cleaning the registry and deleting config files. I know I haven't. We're all just making stabs in the dark and need to patiently wait for the next build.

Personally, I'm using the time to make a list of shows / URLs on which I need to catch up, so that I'm ready to go when we're working again.

hama3254 commented 1 year ago

i just uploaded the U4

@Isaias-Barbosa i set the subtitle download to also use curl that might help but on windows 11 this issue is not there so i can not check it.

for simpler reseting of the settings i added a debug option (right click on any button from the main window) grafik

for the issue with the season download i am unable to find any issue where it might stall itself.

https://user-images.githubusercontent.com/52826614/197387482-511374b1-ee0b-4c29-adb4-86cbf5816eec.mp4

i don't know why the browser does not stay logged in, the cookie as no expering date but i can set it myself which can already bee seen above where i download premium episodes without CR displaying a login that is just a visual but from the website you you press login it notice that you are logged in which is not nessary it's just a demo from me.

https://user-images.githubusercontent.com/52826614/197387516-a92485e5-5ec9-49b2-86a3-cfacb1761486.mp4

ms-ku commented 1 year ago

@Isaias-Barbosa - this Problem/Phenomenon seems normal at the moment. I have this also in Firefox or Opera. After some tries (8-12x) it works again. I think there is a Problem with reCAPTCHA.

@hama3254 - through a miraculous self-healing the login-data will be saved now again since this morning. I also think the Problem was was caused be crunchyroll.com

The Problems of @Serpentstar and @petenun can i confirm but here too, the two links above did not work as complete download till now. But now they work. Also here - Website problem by CR.com? https://www.crunchyroll.com/de/series/G24H1N8XX/berserk-the-golden-age-arc---memorial-edition https://www.crunchyroll.com/de/series/G1XHJV22X/lucifer-and-the-biscuit-hammer

Thanks and greetings msku

Isaias-Barbosa commented 1 year ago

When running, it downloads the subtitles, however, when downloading the video it gives this SSL error. Could it be because of the Windows version? I'm using Win 8 in this print.

image

cimmy01 commented 1 year ago

browser.log First thank you for all of the hard work @hama3254 You are a rock star. That being said I am still having the same issues on U4 as I was on U3. That being the log in cookie not being saved; not being able to change the settings, not being able to download 4 or 5 episodes before the app hangs. Ive included the browser log it does have a few different entries.

pruebark9 commented 1 year ago

I have tried v4 and it still doesn't work for me but I noticed something that is repeated in all versions except V1: it doesn't find CR beta token.

ms-ku commented 1 year ago

Hello

for all with the Problem that the program crashes when they want to save changed settings -> right click of one of the three Buttons on the top -> Clear all settings - this helped me.

@hama3254 - Wenn ich hier "Add-on HTML" klicke - bekomme ich dieselbe Fehlermeldung wie vorher beim Speichern der Settings. In beiden Fällen kommt die Fehlermeldung

"** Ausnahmetext ** System.NullReferenceException: Der Objektverweis wurde nicht auf eine Objektinstanz festgelegt. bei Crunchyroll_Downloader.Einstellungen.Btn_Save_Click(Object sender, EventArgs e) in D:\Projecte\Crunchyroll Downloader - v3.0-final\Crunchyroll-Downloader-v3.0 - CefSharp\Crunchyroll Downloader\einstellungen.vb:Zeile 558.

Ich habe null Ahnung vom Programieren aber sollte/darf hier eine absoluter Pfad stehen der sich höchstwahrscheinlich auf deinen PC bezieht?

Nochmals Danke für deine Arbeit und die Zeit die du investierst - ist ja Wochenende!

@all Sorry guys but sometimes it is faster in the native language

Thanks and greetings msku

petenun commented 1 year ago

@hama3254 Thank you for persevering with this problem. I know it must be frustrating and we appreciate all your hard work. If you want to set-up a mechanism to donate for beer or coffee, I'd be happy to contribute.

Notes on U4: Still having problems getting prompt for episodes after entering series. Still hanging at URL1 / Processing.

CRDownloader.reg.txt

hama3254 commented 1 year ago

@ms-ku das ist eigentlich nur der Code um die HTML von der add-on website die local läuft anzuschauen grafik

grafik

hama3254 commented 1 year ago

@hama3254 Thank you for persevering with this problem. I know it must be frustrating and we appreciate all your hard work.

The only frustrating things are some stupid error i make myself like #554 for every thing else i simply can not find the cause because i don't have that issues.

I was able to download a full series ONCE, on my first launch, but not after that

I'm not even sure how this is possible, some CDN randomness? did CR change something? why does work for me without any issue?

During the one successful series download, I noticed that each episode download took a long time but eventually completed. The download time per episode seemed to be longer than an individual episode download.

That might be just random, i had some episodes change speed while testing them more than once ( again probaly CDN randomness)

Single episodes still download well in general, sometimes without a URL## countdown, though I have gotten a few URL1 / Processing stalls, but single episode downloads eventually seem to start working again after several tries.

it should only do a URL countdown if you either to fast for the downloader to get the beta token or one of request failed and it forwared the download the fallback method.

The Crunchyroll website seems pretty sluggish - even from Chrome, often taking several seconds just to load a page.

i noticed that i had one request running for 14 seconds before i got an answer, this does not really help the downloader...

CR_Cookie value is always blank (Null?), regardless of log-in state

that value was not used in the last version so it never got any data back just the header name without any values

The Clear All Settings is a nice touch, but it doesn't seem to change behavior for me. Perhaps others have had different experiences.

some say it help, other it did not but it's worth a try

Deleting and recreating the CRD-Profile folder also seemed to have no effect.

it had one for me, now i lose login on every restart as well. before that i still had the login from the beta running...