hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
834 stars 110 forks source link

Unable to select resolution #661

Closed abuseddoughboy closed 1 year ago

abuseddoughboy commented 1 year ago

Describe the bug When attempting to download some episodes request me to selct resolution and there are non listed, upon browsing with the browser sometimes it says its unavailable. Doesnt happen on all episodes and its more than one show.

Where does the issue happen?

ghost commented 1 year ago

alt text

occurs randomly with a complete playlist or with individual episodes. If you re-insert the episode, it might work without this error.

hama3254 commented 1 year ago

I have to look at this but if it's random it could come from CR.

Serpentstar commented 1 year ago

It doesn't appear to be completely random,

images ![image](https://user-images.githubusercontent.com/751507/212012683-c2107ee4-58cc-4f63-ace5-fa84b6df772b.png) ![image](https://user-images.githubusercontent.com/751507/212012882-58f746b4-6711-44bf-b7be-6cb70c5282f7.png) ![image](https://user-images.githubusercontent.com/751507/212013325-ca214db2-1300-4676-9611-12595e270166.png) ![image](https://user-images.githubusercontent.com/751507/212013396-4422a6c3-2dfd-4604-9324-3859caa6301e.png)

When I see it, the error is consistent. For example, on the series Ga-rei-Zero, I was able to download ep1 and ep3, but ep2 gives the error. The same applies to the single episode of Kaina of the Great Snow Sea. Error pops up every time. Even after closing and restarting. It feels like CR went and mucked things up again. My resolution is 480P in hybrid mode using MKV and Copy. I am hardcoding English subtitles with chapters.

hama3254 commented 1 year ago

It looks to me like a CR issue. grafik

Serpentstar commented 1 year ago

I discovered something. I went and changed my download resolution to 360P for Kaina of the great snow sea, and it was successful. So there is an possibility that 480p wasn't an option. Would it be possible to put a check in the system where if the first resolution fails, it can fall back to a smaller one? Ga Rei Zero required me to go to 720p for the 2nd episode, so this is looking more and more like CR doesn't have all of the resolutions available for each of their episodes.

ghost commented 1 year ago

as i said its totally random if u have this error try it again and then maybe it works or not. sometimes i need to try it 5 or 6 times to work

it has nothing to do with resolution

hama3254 commented 1 year ago

I discovered something. I went and changed my download resolution to 360P for Kaina of the great snow sea, and it was successful. So there is an possibility that 480p wasn't an option.

i only the error you can see in my screenshot at the top, this mean there are no data at all or it works with every resolution.

Would it be possible to put a check in the system where if the first resolution fails, it can fall back to a smaller one?

the drop down should let you select any available resolution but it is empy since it has no proper error handling for the case of empty or invalid data.

todstelzer commented 1 year ago

Same problem. It's random and works after a few tries
Maybe there should be a check in the code and when this happen wait 10s and try it 5 times and on;y give a error after 5 tries?

AsIFall commented 1 year ago

Screenshot (159) Same problem over here. I first used the version 3.9portable switched to the newly released version after the issue occured several times. I thought I need to update for the problem to be gone but it seems that it does not. Sitting here for almost half an hour trying effortly to download but with no success.

abuseddoughboy commented 1 year ago

so when you navigate to the problem video in the built in browser it just shows a blank video, i can copy and paste the link into firefox and play the video though. I'm an idiot but is there another browser or would there be any way to identify that this app is trying to download from cr? Just trying to come up with ideas.

hama3254 commented 1 year ago

would there be any way to identify that this app is trying to download from cr?

Not impossible but unlikely, if they want to block downloads they would use DRM which is technically difficult to crack and by doing so you would breake the law in multiple countrys.

AsIFall commented 1 year ago

Well, it's no use it seems. The problem still occurs to me. Does not matter how often I start to try downloading the file anew. Will try with another series today.

Akamaru commented 1 year ago

It's still working with v3.11

Crunchyroll_Downloader_2023-01-13_14-11-43

hama3254 commented 1 year ago

Right now it will look for all 3 of the green ones and then use the first it finds. The last git changes the code to check the next one if the request fails, this should improve the success rate. CR would have more streams but the red ones are DRM protected and can not be downloaded, the yellow ones would just not work with the hybrid mode and the two orange ones have limited options. grafik

hama3254 commented 1 year ago

just uploaded v3.13.1 if it works as intended needs to be seen

AsIFall commented 1 year ago

just uploaded v3.13.1 if it works as intended needs to be seen Well, at least it does not show the missing resolution issue again. Screenshot (160)

hama3254 commented 1 year ago

@AsIFall You can use the --insecure to get around that issue grafik

AsIFall commented 1 year ago

Thank you. It works for me now.

todstelzer commented 1 year ago

Hey this seems to work! Thank you for your awesome work with this program. Recording it with OBS is a pain... ^^; Glad it works now :)

petenun commented 1 year ago

Seems to be working great again. Thank you @hama3254. You rock (as usual).

Asklac commented 1 year ago

Greetings friend! I have this problem, how can I solve it? image

hama3254 commented 1 year ago

@Asklac if the build-in web browser works for you fine then you might just have been to fast with clicking download, i should lock the download button until the browser is initialization is completed. If the build-in web browser does not work then you might need the WebView2 Runtime from Microsoft.

stephan1978 commented 1 year ago

hello

wollte bloss sagen das die letzte folge von one piece nicht gut funktioniert nach dem download.

ab 13.30 min sind kodierungsfehler drauf (bild bleibt kurz stehen und der ton läuft nicht syncron)

gruss stephan sonst funktioniert sehr gut

acteias commented 1 year ago

I can no longer download dubbed videos CR changed her player and embedded all the audios can you fix it?