hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
834 stars 110 forks source link

Allow download of closed captions #716

Closed Gotos closed 1 year ago

Gotos commented 1 year ago

It would be great if it was possible to download not just the subtitles, but also the closed captions of shows. I am not entirely sure if #705 is maybe asking about the same thing and was just misunderstood or if maybe I am missing an option to download the closed captions, but so far it seems like the Downloader can only download subtitles.

hama3254 commented 1 year ago

I had to look up the difference between captions and subtitles for #705 and as far i know CR has no captions. The online definition of captions would include all sound as text for people with hearing issues which as far i know are not available on CR. The screenshot on #705 show the data entry closed_caption but it is empty. CR only has the usual subtitles and subtitles for dubbed shows which include text like signs.

Gotos commented 1 year ago

My Hero Academia does have both subtitles and closed captions, at least in the web interface. I'm not sure where the json on your screenshot is from, so I couldn't verify if the caption entry is empty for MHA as well, but I assume it's just a matter of only few shows having closed captions at this point.

hama3254 commented 1 year ago

For me on My Hero Academia i only get one subtitle for Episode 1 at least. grafik

Gotos commented 1 year ago

On German crunchyroll that might be true, but on American crunchyroll I have access to closed captions. As far as I know, MHA season 6 is available in English even on German crunchyroll, can you check if you have CCs available there? grafik

hama3254 commented 1 year ago

On season 6 (Episode 114) with englisch dub i have some there. I can add this like suggested in #705 but if you need CCs than you probably don't need normal subtitles anymore so a setting that preferess CCs over subs would be my choice for the rare cases we even get CCs. grafik

Gotos commented 1 year ago

Sounds good to me. If in doubt I could then still download one first and the other afterwards. Thanks! :)