hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
844 stars 108 forks source link

Queue changes #765

Closed tormento closed 1 year ago

tormento commented 1 year ago

I have some requests about queue:

  1. Have process queue switch enabled as default
  2. Arrows to change download order of selected onese plus a button to delete them
  3. Have episodes index processed separately from queue, so that we can add more episodes when others are alread queued.
hama3254 commented 1 year ago
  1. Have process queue switch enabled as default

The default is off.

2. Arrows to change download order of selected onese

The downloader is not build for bulk downloads, you rarely watch more than a season (12 epidsodes) per day so that is what i set as session target.

plus a button to delete them

a double click should delete items from the queue.

3. Have episodes index processed separately from queue, so that we can add more episodes when others are alread queued.

i have no idea what you want to do but the last time i checked everything worked as intended.

tormento commented 1 year ago

The default is off.

Ok. A matter of personal preferences.

The downloader is not build for bulk downloads, you rarely watch more than a season (12 epidsodes) per day so that is what i set as session target.

Sometimes I download whole seasons in a row. If not possible, it's ok :)

a double click should delete items from the queue.

Didn't know that. Will try ASAP.

i have no idea what you want to do but the last time i checked everything worked as intended.

When you ask for the index of an entire anime/season, it goes in the queue and you need all the episodes to be downloaded to have what you want.

hama3254 commented 1 year ago

The default is off.

Ok. A matter of personal preferences

You have to keep in mind there are more than just we two using the downloader. The last version (v3.15.5) already has 304 downloads with the old v3.8.9 having close to 8800 downloads. So i chose opt-in rather than opt-out if i have no strong reason otherwise.

When you ask for the index of an entire anime/season, it goes in the queue and you need all the episodes to be downloaded to have what you want.

The season download can be redirect into the queue but does not have to. So you can close the queue and use the season download without it.

tormento commented 1 year ago

The season download can be redirect into the queue but does not have to. So you can close the queue and use the season download without it.

I mean download the index of a season, not a season itself. If you download an index when the queue is processing, it will go in queue too.

hama3254 commented 1 year ago

I think i now see what you mean, it just adds the series url to the queue. This seems due to the download count being full with the queued videos. grafik

hama3254 commented 1 year ago

Series urls won't be added to the queue anymore if it's running. grafik

tormento commented 1 year ago

image

Not exactly what I wanted. I'd prefer to have the index loaded in a new process separated from queue, so that we can add other seasons/episodes while the queue is downloading.

hama3254 commented 1 year ago

loaded in a new process separated from queue

the queue and the mass download run on the same thread and need to access shared ressurcess so this it not going to work even if wanted to.