hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
844 stars 108 forks source link

Crash when trying to download a certain episode from Crunchyroll #777

Closed guitarjorge24 closed 1 year ago

guitarjorge24 commented 1 year ago

There's a crash when trying to download episode 11 of The Ancient Magus' Bride Season 1 https://www.crunchyroll.com/watch/GR9PQ5G86/lovers-ever-run-before-the-clock

I tried about 5 times and it happens every time. Other episodes from the same season download properly. Only episode 11 causes the crash.

Where does the issue happen?

hama3254 commented 1 year ago

i don't see anything wrong with that episode. please check that you have the latest version and if it still does not work than please provide the FFMPEG-Logfile for this entry. grafik

bybpow commented 1 year ago

Same here: https://www.crunchyroll.com/es/watch/GN7UDWNP2/end-of-terminus-exams--girls-talk

It happens to me when the dub is Japanese.

hama3254 commented 1 year ago

@bybpow i would need more data on that to know what is wrong because it does not happen for me. grafik

bybpow commented 1 year ago

What Can I provide? Settings? As the app crashes I can't provide a logfile.

hama3254 commented 1 year ago

As the app crashes

oh the whole downloader crashes? windows should do log of that in it's event view.

You should find the log here (my windows is set to German but it should look similar) grafik

bybpow commented 1 year ago

This is the log and the exported events. Hope this is helpful.

2023-07-02 18_53_36- crdl.zip

hama3254 commented 1 year ago

@bybpow i added Crunchyroll-Downloader-v3.15.5.2.zip with some changes to a retry function. i assume that retry function gets called since it goes from Crunchyroll_Downloader.Main.GetCRVideo to Crunchyroll_Downloader.Main.LoadBrowser which should only happen there.

I also want to note that the event states Version: 10.0.19041.3155 which should be Windows 10 2004 and the downloader is not tested on older Windows 10 build. i currently use : grafik

bybpow commented 1 year ago

I updated. The new fix solves the crash problem but the ep. still doesn't download. Same with ep. 14 so far. v3.15.5.2.log

guitarjorge24 commented 1 year ago

i don't see anything wrong with that episode. please check that you have the latest version and if it still does not work than please provide the FFMPEG-Logfile for this entry.

Hi, I do have the latest version 3.15.5. It looks like if I delete my user.config file then it doesn't happen anymore so it requires a particular setting.

I have attached my user.config here: User.config.zip

and here's my log crunchy downloader log.txt

guitarjorge24 commented 1 year ago

yeah, it looks like after I wipe the settings it works and then if I change the softsubs to "english" then it crashes: image

hama3254 commented 1 year ago

i found the issue with those two episodes, it only happens with unmerged englisch subtitles since they containt either of those

grafik

this lead to the issue since error are reportet like this curl: (22) The requested URL returned error: 400

and everything behind the : can change so in my infinite wisdom i used curl to dectect issues.

This should however not make the downloader crash fully so i also remove the retry function and add a discalmer to finish running downloads and then to restart the downloader.

hama3254 commented 1 year ago

the release has an updated version now.

guitarjorge24 commented 1 year ago

lol I see, that happens! it's working for me now, thanks

luccaslil commented 1 year ago

Captura de Tela (1) help pls

bybpow commented 1 year ago

Are you logged in to the browser? Share the URL to try to reproduce.