search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
848 stars 109 forks source link

Error if skip hardsubs is not selected and there are no hardsubs #893

Closed tkirkland closed 5 months ago

tkirkland commented 5 months ago

Describe the bug If you have the attempt to grab hardsubs and the downloader detects that there are no hardsubs in your default language, you are prompted to select another language. If you select 'No hardsubs' either because there are none or you don't want any of the available choices, this is when the error in image three happens. Your only option now is to cancel, go into preferences for CrunchyRoll and enable 'skip hardsubs...'

Apologies for the large images... On a 4k display and saw no way to resize them. If I missed it let me know.

Where does the issue happen?

Screenshots image image image

hama3254 commented 5 months ago

the whole code of the hardsub error handling was outdated and is now replaced with a new version. i wonder why this was not a bigger issue since half the sub would have caused the same issue as No Hardsubs did.

Anyway the new v3.17.2 build should fix this now.

tkirkland commented 5 months ago

Perfect, I'll test it and let you know.

tkirkland commented 5 months ago

Working fine. Thanks. Closing.