hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
841 stars 109 forks source link

[Crunchyroll-Downloader-v3.20] #926

Closed hama3254 closed 5 months ago

hama3254 commented 6 months ago

neither the release note(s) or the commit are exaggerated, the code is really that bad. So this is a fresh thread for all the issues i caused that i did not find.

switch api version held together with copium.

switch to the new api (switch endpoiunt)

switch to the new api with every abomination i could think of

619beave commented 6 months ago

Wow! This is a great Birthday present for me :)

I thoroughly tested the build and it works!!!

Thanks for the Update.

SteamFab was a struggle to use.

x3inspire commented 6 months ago

Anyone getting error like this?

image

joseant0910 commented 6 months ago

image

Hi! I'm getting this error:(

Anonymous327 commented 6 months ago

image

Hi! I'm getting this error:(

That seems to happen when you have hardsubs turned on. No issues with softsubs. Ah. That happens when you have both hardsubs and softsubs turned on. Turn softsubs off for it to work normally. Also, downloading the same video more than once causes weird errors. Like it should automatically rename or something instead of trying to merge with the existing video file? Anyway, noticed that as I was playing with the settings and downloading stuff with different settings.

Anonymous327 commented 6 months ago

Anyone getting error like this?

image

Make sure you download the latest version and replace the old one with it.

joseant0910 commented 6 months ago

image

I just disabled hardsubs, enabled softsubs and keeps crashing. Before, I also deleted any remaining copy of the video

Natsume-197 commented 6 months ago

Same error even with softsubs enabled or disabled, It may have something to do with the content that is downloaded.

imagen

Glad to see that the project hasn't died!

Anonymous327 commented 6 months ago

I just disabled hardsubs, enabled softsubs and keeps crashing. Before, I also deleted any remaining copy of the video Same error even with softsubs enabled or disabled, It may have something to do with the content that is downloaded.

Are you on the latest version of the software? What do your settings look like? @joseant0910 @Natsume-197

joseant0910 commented 6 months ago

I just disabled hardsubs, enabled softsubs and keeps crashing. Before, I also deleted any remaining copy of the video Same error even with softsubs enabled or disabled, It may have something to do with the content that is downloaded.

Are you on the latest version of the software? What do your settings look like? @joseant0910 @Natsume-197

Yes! I downloaded the one released today. V 3.20 image

Anonymous327 commented 6 months ago

Yes! I downloaded the one released today. V 3.20

And I assume you are a CR subscriber? Make sure you are logged in. @joseant0910 I'm having no issues downloading hardsubs or softsubs in any language, so I can't fathom what the issue is.

joseant0910 commented 6 months ago

Oh yes, I am. Otherwise, I wouldn't be able to get the right link

[Image removed - hama]

Anyway, I'll try re downloading the program

Anonymous327 commented 6 months ago

Oh yes, I am. Otherwise, I wouldn't be able to get the right link Anyway, I'll try re downloading the program

What Output settings are you using? That may be the culprit. Always remember that when a new version is released, you don't have to start fresh. Just extract and drag and drop the new files into the old folder and replace the old ones that way.

Anonymous327 commented 6 months ago

image

Thanks! Anyway, I just re downloaded the program and the error still there

That's the issue. Change the download mode to Hybrid Mode. See if that fixes your issue. In case you ever use softsubs, turn MKV and copy on under Format, and check add 'ScaledBorderAnd Shadow:yes' to subtitles under mods. I played with MP4 mode as well, and it downloads softsubs just fine with hardsubs on. I think your issue is the download mode.

hama3254 commented 6 months ago

@joseant0910 I check the settings you used later, in the meantime please don't post any personal data (like the your username).

hama3254 commented 6 months ago

Anyone getting error like this?

image

@x3inspire this is an issue with the WebView2 please check that it is installed and that the Edge browser it is based on works.

Anonymous327 commented 6 months ago

Thank you so much for your patience!! It now seems to be working well

Great! Not sure why the Default - ffmpeg mode exists when it never works. 😑 Any thoughts on why that is? @hama3254 Maybe Hybrid Mode should just be the default mode? Edit... Just checked and it does indeed work for me but is much slower than Hybrid. It's possible there are prerequisites to download with ffmpeg that some aren't aware of. I just remembered that Hybrid exists for merging subs with video files as well.

joseant0910 commented 6 months ago

@hama3254 Thank you!! I'll be more aware!

joseant0910 commented 6 months ago

@hama3254 @Anonymous327 By the way, when the download started, it automatically created a new folder. I really don't know too much about this, so I wanted to know if it's normal. Never happened before (when using ffmpeg)

Anonymous327 commented 6 months ago

@hama3254 @Anonymous327 By the way, when the download started, it automatically created a new folder. I really don't know too much about this, so I wanted to know if it's normal. Never happened before (when using ffmpeg)

Seems new to me too, but it does delete the folder once it's complete so... 🤔

Anonymous327 commented 6 months ago

Did some more investigating as well. ffmpeg mode and hardsubs won't work. @hama3254 @joseant0910 ffmpeg works fine, but only when I have MKV, copy/srt, and softsubs enabled though. Did not work with MP4.

joseant0910 commented 6 months ago

@Anonymous327 Thank you!! I'll keep that in mind

Anonymous327 commented 6 months ago

@Anonymous327 Thank you!! I'll keep that in mind

I assume this worked before though? Guess it's a bug if so.

joseant0910 commented 6 months ago

@Anonymous327 Thank you!! I'll keep that in mind

I assume this worked before though?

Well, it was working well to me until the v 3.17

hama3254 commented 6 months ago

It is very well possible that not all settings work, I simply don't had the time to test all of them (I mean there a view :/ )

joseant0910 commented 6 months ago

It is very well possible that not all settings work, I simply don't had the time to test all of them (I mean there a view :/ )

Yup! Don't worry! As I said in the other thread, thank you for all your work and effort!

hama3254 commented 6 months ago

@hama3254 @Anonymous327 By the way, when the download started, it automatically created a new folder. I really don't know too much about this, so I wanted to know if it's normal. Never happened before (when using ffmpeg)

Seems new to me too, but it does delete the folder once it's complete so... 🤔

I assume that the hybrid mode folder. I had a explanation video but YT did not like it.

screenshot ![Screenshot_2024-04-05-06-55-31-37_680d03679600f7af0b4c700c6b270fe7](https://github.com/hama3254/Crunchyroll-Downloader-v3.0/assets/52826614/52858465-345e-473a-af53-a8d0f8fb07a4)

The tldr would be I download all files from the stream, generate a local copy that then gets processed by ffmpeg which now has much faster access. The speedup comes from the fact that I can download more of the segments at the same time compared to ffmpeg which does it 1 by 1.

Anonymous327 commented 6 months ago

@hama3254 @Anonymous327 By the way, when the download started, it automatically created a new folder. I really don't know too much about this, so I wanted to know if it's normal. Never happened before (when using ffmpeg)

Seems new to me too, but it does delete the folder once it's complete so... 🤔

I assume that the hybrid mode folder. I had a explanation video but YT did not like it.

screenshot The tldr would be I download all files from the stream, generate a local copy that then gets processed by ffmpeg which now has much faster access. The speedup comes from the fact that I can download more of the segments at the same time compared to ffmpeg which does it 1 by 1.

Gotcha. Well, I suppose for now it would be best to tell people that ffmpeg mode has limited functionality while Hybrid Mode has full functionality. For the WebView2 issue, I assume people just need to install this? https://developer.microsoft.com/en-us/microsoft-edge/webview2/?form=MA13LH I don't remember installing anything like that, so it must come with Microsoft Edge now.

GHCripto commented 6 months ago

thank you very much for your work again, this works great <333333 Captura de pantalla 2024-04-05 033154

Do you think that in any future update it will be able to support Music Videos? image

AsIFall commented 6 months ago

To those who suggested switching APIs and revived this project. You should be considered to be a hero. Thank you very much. It works fine for me. Even downloading hardsubs.

ghost commented 6 months ago

Well done! Those who are said to be dead live longer! ;-)

ms-ku commented 6 months ago

Hallo Hama

schön das es weitergeht !!! Hoffentlich bekommst du keine Probleme mit deiner Familie - wegen dem Haus und so ;-). Ich habe nur ein Problem. Der Download ist zu schnell (zumindest für mich). Ja ich weiß, hört sich blöd an aber meine 50Mbit Leitung wird nun mit einem Download von CRD voll ausgelastet. Früher waren es bei 2 so was um die 30-40%. Da ich ungern bei CR auffallen möchte habe ich nun erst einmal Netlimiter installiert. Ist aber nur ne 30 Tage Testversion. Gibt es im CRD die Möglichkeit einer Begrenzung oder kennt jemand ein kostenloses Tool mit welchem man die Downloadgeschwindigkeit für einzelne Programme begrenzen kann?

Danke und Grüße msku

hama3254 commented 6 months ago

Gibt es im CRD die Möglichkeit einer Begrenzung

es gibt die option die threads zu reduzieren was den download langsamer machen sollte.

grafik grafik

hama3254 commented 6 months ago

Did some more investigating as well. ffmpeg mode and hardsubs won't work. ffmpeg works fine, but only when I have MKV, copy/srt, and softsubs enabled though. Did not work with MP4.

that issue was just a view lines that changed the ffmpeg command. without merged subs it made it like that.

05.04.2024 07:29:55 -user_agent "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36 Edg/123.0.0.0" -headers "ACCEPT-ENCODING: *" -protocol_whitelist file,http,https,tcp,tls,crypto,data -allowed_extensions ALL -i "C:\Crunchyroll-Downloader-v3.20\CRD-Temp-File-xqo8mmdsaqp1hhoj.m3u8" -metadata:s:a:0 language=eng -c copy -c:a copy -bsf:a aac_adtstoasc "C:\Documents\RWBY Season 2 Episode 4.5.mp4"

05.04.2024 07:29:55 Option user_agent not found.

just to not find the option since it's using a local copy not a http request where it could use the headers.

progithub2 commented 6 months ago

@hama3254 Hochachtung! Klasse gelöst. Kann man nur den Hut ziehen! Chapeau!!!!! Hast echt was auf dem Kasten!

Ich hatte mich schon mit anidl abgefunden. Das Tool ist zwar nicht schlecht, aber deins ist einfach eine andere Klasse.

Bin neidisch auf dein Können!

progithub2 commented 6 months ago

@ms-ku @hama3254 das mit dem Limit ist eine super Idee - hab das gleiche Problemchen.... Aber der Vorschlag mit dem set hybrid-mode thread count bringt bei mir direkt keine Veränderung, habs von 8 auf 4 heruntergesetzt. Leitung wird aber immer noch voll ausgelastet (so nebenbei).

ms-ku commented 6 months ago

Ich weiß ja nicht ob es am neuen Client oder am Hybrid Mode liegt aber der Download ist schon sehr schnell. Der Balken "donnert" im wahrsten Sinne nach rechts :-). Bei mir hat der Thread Count auch nix gebracht. Ich teste gerade BWMeter und TMeter. Beide Programme sind Freeware und zügeln den CDR. Mein Favorit ist z.Zt. BWMeter. Grüße msku

hama3254 commented 6 months ago

Ich weiß ja nicht ob es am neuen Client oder am Hybrid Mode liegt aber der Download ist schon sehr schnell. Der Balken "donnert" im wahrsten Sinne nach rechts :-). Bei mir hat der Thread Count auch nix gebracht. Ich teste gerade BWMeter und TMeter. Beide Programme sind Freeware und zügeln den CDR. Mein Favorit ist z.Zt. BWMeter. Grüße msku

@ms-ku @hama3254 das mit dem Limit ist eine super Idee - hab das gleiche Problemchen.... Aber der Vorschlag mit dem set hybrid-mode thread count bringt bei mir direkt keine Veränderung, habs von 8 auf 4 heruntergesetzt. Leitung wird aber immer noch voll ausgelastet (so nebenbei).

Ich hab leider nur noch 75k im Download also lässt sich das nicht mehr testen aber soweit ich bisher gesehen habe (auch in https://github.com/hama3254/Crunchyroll-Downloader-v3.0/issues/918#issuecomment-2034431778) ist es tatsächlich ein anderer CDN Anbieter.

Alles reine Spekulation aber ich würde mir da keine Sorgen machen gebannt zu werden, sonst hätten die das längst bei mir gemacht mit den ganzen ungültigen API anfragen bzw den sonstigen tests von mir 🤐.

ms-ku commented 6 months ago

Hallo Hama bei den normalen wöchentlichen update Downloads habe ich auch nicht so das Problem/die Bedenken damit. Allerdings wenn ich mal eine komplette Serie mit ein paar Staffeln am Stück lade da mache ich mir schon Gedanken um meinen günstigen indischen Account. Ich kenne es von meiner Arbeit her, da schaut man sich auch nur immer mal wieder die großen Peaks beim Datenverkehr an. Wenn dann einmal öfters was auffällt, dann schaut man halt einmal genauer hin. 75k - du hast aber eine gute ISDN Leitung ;-) Grüße

hama3254 commented 5 months ago

@GHCripto looks good so far. grafik

Gruphius commented 5 months ago

3.20.1 and 3.20 give me a constant 401 error Bild_2024-04-09_214710966

hama3254 commented 5 months ago

@Gruphius 401 would mean unauthorized which may because the anonymous request is not added yet (https://github.com/hama3254/Crunchyroll-Downloader-v3.0/issues/918#issuecomment-2036908991) try to login into any type of account (free or premium).

Gruphius commented 5 months ago

@Gruphius 401 would mean unauthorized which may because the anonymous request is not added yet (#918 (comment)) try to login into any type of account (free or premium).

It worked, thank you!

GHCripto commented 5 months ago

@GHCripto looks good so far. grafik

thank you so much, this is glorious again!! :'D <3 Captura de pantalla 2024-04-11 045304

ZolXick commented 5 months ago

Hello Hamma, This is my problem, everything was normal if I had logged in but now overnight this appears when I try to download I get the first image, after I accept I get the second image, I would be grateful if you can find one solution in the same way. Does anyone else have the same thing happen to me? 1 2

ZolXick commented 5 months ago

The version I have is v.3.20.1, I think it is the most updated

hama3254 commented 5 months ago

@ZolXick i uploaded v3.21 as it is from the current code base (last git) and i don't see any issue there.

xmanuelx1985 commented 4 months ago

image I get this error, can someone help me please?