search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
834 stars 110 forks source link

Hardsub in Dub video #933

Closed Raphael1512 closed 6 months ago

Raphael1512 commented 6 months ago

Hi, is it possible to add the functionality to imprint subtitles in dubbed videos? (the language in question is Italian) For example, episode title or signs, etc. The softsubs work perfectly while the hardsubs do not print them.

hama3254 commented 6 months ago

We got the setting for hardsubs. grafik

this will tell the downloader to use the stream tagged as hardsub in the language you selected. What this files contains comes from CR.

grafik

Raphael1512 commented 6 months ago

It's very strange... I checked the settings and they are correct, I tried to download an episode in Italian but the forced subtitles are not printed on the video. I can't understand why

Raphael1512 commented 6 months ago

EDIT: I noticed that it doesn't work with all anime, in some it makes me hardsub easily, while in others it doesn't print.. for example my hero academy season 6 it can't print.

hama3254 commented 6 months ago

EDIT: I noticed that it doesn't work with all anime, in some it makes me hardsub easily, while in others it doesn't print.. for example my hero academy season 6 it can't print.

with the way this works the downloader only check the tag of the stream so if the hardsubs are not there then CR did not include it. Did you check if the text is included in the softsubs for that dubbed episode?

Raphael1512 commented 6 months ago

Yes, I checked, and the text is always downloaded in softsub

hama3254 commented 6 months ago

If the same settings give different results than this is on CR.

But i can offer a workaround.

If you select the softsub and set it as the default subtilte while using mkv and copy this will add the subtitle text file into the video file and just give you One .mkv file that almost all modern player can use.

For bonus points i would recomment the Hybrid Mode and the ScaledBorderAndShadow:yes option to fix some issues (#764 and #871)

grafik

Raphael1512 commented 6 months ago

If it's a CR problem, then I'll do as you said, thank you very much🙏