hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
850 stars 109 forks source link

Crunchyroll-Downloader-v3.22 #941

Closed hama3254 closed 1 month ago

hama3254 commented 2 months ago

Due to changes to the API users now get promted to add there login credentials before the videos can be added. By defaul this will only be used for that session, a save option is avalible. grafik

progithub2 commented 2 months ago

@hama3254 Chapeau - du hast es wieder einmal geschafft. Hochachtung!

ridaatyy commented 2 months ago

image

TaMaGo-TTV commented 2 months ago

Insane work. Big Thank you from Gemany

Edit: ffmpeg got fixed too, lets goo

619beave commented 2 months ago

Works for me, Just needed to make sure the CR login is correct

segurafifa2006 commented 2 months ago

Version 22 already skips this screenshot[

https://postimg.cc/bZ682zS6[](url)

hama3254 commented 2 months ago

@ridaatyy if there are no other errors before that than it's likely you just got a free account but the episode is not free. otherwise i would check the login details and that you got the latest version.

hama3254 commented 2 months ago

@segurafifa2006 401 indicates that you might got something wrong with the login details. Unfortunately i did not add a way to reset the login details in the current build, so if you saved them you might need to reset the Downloader (delete the folder and un-zip it again)

Animes2024 commented 2 months ago

Unfortunately i have the same problem like @ridaatyy. I downloaded and installed v3.22, logged in and saved my credentials in the downloader and also have an active premium membership and it still says "Status: Failed - no video, check CR login".

Screenshot

Edit: I give it an other try and it failed again, but here the log (if it could help) from the new try:

v3.22 Thread Name: Main NavigationCompleted: 21.04.2024 17:02:08 21.04.2024 17:02:08.148 https://www.crunchyroll.com/de Just Browsing, exiting... what's going on?: 21.04.2024 17:02:52 19 Post error!, 400 -d "grant_type=client_id&scope=offline_access" -X POST ObjectsUrl: https://www.crunchyroll.com/content/v2/cms/objects/G0DUND0K2?preferred_audio_language=ja-JP&locale=de-DE Status: Failed - no video, check CR login

loddar66 commented 2 months ago

image

I also get this 'unauthorized' error message. I have a premium account and in a first trial, I just typed my mail address and password; then I pasted them- without success. Both are containing some special characters, could this be the root cause?

Serpentstar commented 2 months ago

This error comes up if there is a queue. One episode downloads, then it fails with the below error, then the next episode completes. image

If I download just one episode at a time, it seems to work as intended.

Serpentstar commented 2 months ago

image

I also get this 'unauthorized' error message. I have a premium account and in a first trial, I just typed my mail address and password; then I pasted them- without success. Both are containing some special characters, could this be the root cause?

I know from work experience that some special characters can cause problems in passwords when saved because they are also used to define boundaries within an xml. Try not using any of these: <>/'",#[]() Or try making a ridiculously long password of alphanumerical characters only. I tend to use 20 to 30 characters in mine.

image Looks like I couldn't even say not to use these here.

Animes2024 commented 2 months ago

Another thing I have noticed is that when I start the downloader for the first time after unzipping and want to log in to the browser, the first login always fails, the second login attempt always works first.

M steps are unzip downloader -> edit settings -> log in to browser -> store credentials in downloader

hama3254 commented 2 months ago

i am not quite sure whats the cause here, but missing the option to change the login details and not encoding the user input at all was not the best idea. i don't know if the new upload fixes the issues but you can try.

Animes2024 commented 2 months ago

Unfortunately still not working :(

Log:

v3.22.1 Thread Name: Main NavigationCompleted: 21.04.2024 18:32:58 21.04.2024 18:32:58.992 https://www.crunchyroll.com/de Just Browsing, exiting... what's going on?: 21.04.2024 18:33:00 18 Post error!, 400 -d "grant_type=client_id&scope=offline_access" -X POST ObjectsUrl: https://www.crunchyroll.com/content/v2/cms/objects/G4VUQ5KQW?preferred_audio_language=ja-JP&locale=de-DE Status: Failed - no video, check CR login

Screenshot

loddar66 commented 2 months ago

thanks for the update - at least the error message is a bit clearer now. ;-) Nevertheless, it's still not working for me - even after changing my password as suggested by @Serpentstar. By the way - my mail address includes a '+'... 'crunchy-cli' can handle this combination w/o any issues (it also worked with the old password) - so at least the fall-back solution is working for now.

segurafifa2006 commented 2 months ago

Crunchyroll-Downloader-v3.22.1 Every time I go to download a video I get this message and it doesn't go from there Cr Reported error 401 this may mean incorrect login deatail

hama3254 commented 2 months ago

The only variable are login an password and as result the account itself. It does work for me and even others so i have no idea why this would return 400.

for @segurafifa2006 did you check that email and password are correct?

Gremory17 commented 2 months ago

image Probe con 2 usuarios uno con caracteres especiales y otro sin caracteres especiales el que no tiene caracter especial en la contrase;a si dejo entrar perfectamente y descargar

segurafifa2006 commented 2 months ago

I have changed the password but it still does not accept it and it keeps doing the same thing

Serpentstar commented 2 months ago

I know for email experience that trying to use + addressing will cause issues with some systems. specially ones based on Linux. For those having issues, does your either address or password contain non alphanumeric characters? Besides the address having a . and a @ that is. Since it is more than one person, perhaps identifying a common thread could help. This also goes for accented characters. I know that pretty much every language aside from English has them, and sometimes the encoding of them breaks when decoded.

SilverWolf077 commented 2 months ago

English: Good 👍, CRD works perfectly up to this moment. I changed my password because it had special characters and followed Animes2024's steps and everything accepted it with no problems. Thank you hama3254.

Español: Bien 👌, CRD trabaja perfectamente hasta este momento. Cambié mi contraseña porque tenía caracteres especiales y seguí los pasos de Animes2024 y todo lo aceptó sin problemas. Gracias hama3254.

loddar66 commented 2 months ago

Of course I could use any other mail address, but it should also work for those who use the "Gmail address trick", where a '+' sign followed by a string is inserted into the first part of the address... As an engineer, I would now like to witness the solution to the problem instead of just working around it. 😉

Animes2024 commented 2 months ago

Wow, apparently certain characters in the password also cause error 400 (in my case the password contained the characters ;:_) and after a password change everything works again as usual. But it is strange that I was able to log in to the downloader in the built-in browser but the downloader does not display an error message or anything and at first look it looks like the login works.

Maybe it would be useful to display a small hint in the downloader regarding special characters or to check the entered password for special characters and if there are any, a hint appears that you should change the password so that it works with the downloader. But that actually goes far beyond the actual purpose of the downloader. Maybe i'll test again later with which special characters it is exactly problematic.

hama3254 commented 2 months ago

Just realized i used HtmlEncode not UrlEncode it does work with this new (non premium) account with a ' and the + for the gmail feature. grafik

Animes2024 commented 2 months ago

Ah okay... Whats the difference between them? Unfortunately i don't know much about programming.

And this means special chars should work overall now?

loddar66 commented 2 months ago

Just realized i used HtmlEncode not UrlEncode it does work with this new (non premium) account with a ' and the + for the gmail feature.

that did the trick, thanks!

LTech77 commented 2 months ago

Oh well, it didn't last long. grafik Still hoping for a fix.

Animes2024 commented 2 months ago

Oh well, it didn't last long. grafik Still hoping for a fix.

I have no problems downloading stuff (I am still using v3.22.1)

Midnighit commented 2 months ago

The "override Dub language" checkbox doesn't seem to be working (anymore?). If I have English selected on Crunchyroll it will always download the english dub (and sub) regardless of which language I have selected in the downloader even when the "override Dub language" checkbox is selected. Changing the language in Crunchyroll directly and using the new URL to download the video still works though.

Not necessarily a bug but maybe something I did wrong: I have been unable to merge an existing video file with a different audio track. Changing the language on Crunchyroll, copying the new URL and then selecting merge audio (without changing any of the naming settings or having the language as part of the name) will properly select that dub for downloading and attempt to download the video in 480p. It gives the existing video file a temp name and then crashes.

Also something I may be doing wrong: The subtitles are shown as being available in the video file and I can select them but nothing is actually displayed. I Tried both copy and srt (what does copy mean?) in conjunction with mkv as format but nothing works.

Last but not least: I don't suppose it's possible to download multiple subtitle languages in one go? Looks like a Crunchyroll limitation since I can only ever select the language of the dub as subtitle language there as well, but if it's something I'm doing wrong, I'd love to hear about it.

ZolXick commented 2 months ago

Hello hamma, this comes up, sorry to bother you, I attached an image. image

ZolXick commented 2 months ago

Yes I am logging in correctly but it is from hotmail so I don't know if that affects it, please help

lobito618 commented 2 months ago

The minimum password must be 15 in length, try changing the password and try again

ZolXick commented 2 months ago

La contraseña mínima debe tener una longitud de 15, intente cambiar la contraseña y vuelva a intentarlo.

I already changed it, as you say, but I still get that 401 error

lobito618 commented 2 months ago

When you change your password, it tells you if the password is simple or strong (it complies with everything the system requests), try downloading Crunchyroll-Downloader-v3.22 again and see if the password complies with what the system requests.

ZolXick commented 2 months ago

Well I repeat anyway, if I looked and now even this is what you mentioned which is now 15, it allows me everything and it doesn't allow me to download, I'm going to try the other versions although I think it's the same

loddar66 commented 2 months ago

the 'Code' page labels 3.22 as the latest version - but you must select 3.22.2 to get the latest user/pw fix... image

Animes2024 commented 2 months ago

One thing i noticed (i am using v3.22.1, can anyone confirm this for v3.22.2?):

After a few hours the queue is simply canceled ("CR something went wrong"- error message from the downloader) and when I open the built-in browser I see that I am no longer logged in to CR (I logged in again in the browser) and you have to restart the downloader to be able to download something again. Happened to me twice tonight (the second time I was smart enough to save the log).

RisedSky commented 2 months ago

One thing i noticed (i am using v3.22.1, can anyone confirm this for v3.22.2?):

After a few hours the queue is simply canceled ("CR something went wrong"- error message from the downloader) and when I open the built-in browser I see that I am no longer logged in to CR (I logged in again in the browser) and you have to restart the downloader to be able to download something again. Happened to me twice tonight (the second time I was smart enough to save the log).

Never tried this for long that far.. Prefer doing like, 1 series after one and to restart the program sometimes to prevent some kick from CR

Animes2024 commented 2 months ago

One thing i noticed (i am using v3.22.1, can anyone confirm this for v3.22.2?): After a few hours the queue is simply canceled ("CR something went wrong"- error message from the downloader) and when I open the built-in browser I see that I am no longer logged in to CR (I logged in again in the browser) and you have to restart the downloader to be able to download something again. Happened to me twice tonight (the second time I was smart enough to save the log).

Never tried this for long that far.. Prefer doing like, 1 series after one and to restart the program sometimes to prevent some kick from CR

Some time ago I downloaded over 30-40 hours per session without any errors

segurafifa2006 commented 2 months ago

v3.22.2 I already changed the password to 8 characters as stated but I still get the 401 error I have also made another different account and the same thing happens

Animes2024 commented 2 months ago

v3.22.2 I already changed the password to 8 characters as stated but I still get the 401 error I have also made another different account and the same thing happens

Do you use your E-Mail-Adress to login or username?

Edit: And do you have an active premium membership on your accounts?

crunchydll commented 2 months ago

Good morning, For my part I get this error when I try to download... I can download a maximum of 13 episodes, even if I download a full season of 24 episodes the software stops at 13. And then I have to reopen it 5/6 times before I can redownload the rest image

segurafifa2006 commented 2 months ago

Thank you so much I have entered the Crunchyroll Premium email and password and it works

Serpentstar commented 2 months ago

@crunchydll Instead of closing and retrying, it could be a timing factor. Download 12 episodes, then wait 10 minutes and try again. If you are seeing consistent behavior, identifying a pattern may help to understand if it is a limitation that CR has in play.

IchYoIo commented 2 months ago

Thanks for the upgrade.

Some episodes still crashing

Can you check some links, that Crash when DW start?

https://www.crunchyroll.com/es/watch/GQJUG3W7Z/balsam-and-woodsorrel CR DW Crash

sahtanoj commented 2 months ago

@hama3254 , thank you very much for your effort. Just stopping by to let you know that today I'm having difficulty downloading all the subtitles for the same title/anime. I refer to the version Crunchyroll-Downloader-v3.22.2 For some reason, the video file is downloading, but the subtitles are not always downloaded along with it. Not even the version of CR Downloader that only downloads subtitles can download them 100%. Of course, I don't know if the problem is with CR or CR Downloader. But I decided to stop by just to report this problem to you. Example: When downloading the complete Sousou no Frieren dubbed in Portuguese, the forced subtitles are downloaded from ep 01 to 17, then fail to download from 18 to 26, and download again from 27 to 28. The same is happening with other titles.

Another detail I noticed was the CR Downloader browser login failure. Previously there was more consistency when logging in.

crunchydll commented 2 months ago

@crunchydll Instead of closing and retrying, it could be a timing factor. Download 12 episodes, then wait 10 minutes and try again. If you are seeing consistent behavior, identifying a pattern may help to understand if it is a limitation that CR has in play.

It seems that indeed by making a maximum of 12 episodes and leaving around 2 to 5 minutes of cooldown, I have no errors I still have the error, but I can download a little further

IchYoIo commented 2 months ago

Thanks for the upgrade.

Some episodes still crashing

Can you check some links, that Crash when DW start?

https://www.crunchyroll.com/es/watch/GQJUG3W7Z/balsam-and-woodsorrel CR DW Crash

SOLVED Not every episode support Hybrid Mode, all the episodes DL when I change to ffmpeg. @hama3254 superb work.

hama3254 commented 2 months ago

Not every episode support Hybrid Mode, all the episodes DL when I change to ffmpeg. @hama3254 superb work.

@IchYoIo All episodes should work with both modes, for any issue i would need the log to take a look at. It also works fine for me. grafik

IchYoIo commented 2 months ago

Not every episode support Hybrid Mode, all the episodes DL when I change to ffmpeg. @hama3254 superb work.

@IchYoIo All episodes should work with both modes, for any issue i would need the log to take a look at. It also works fine for me. grafik

On Hybrid Mode 23/04/24 12:26:34 [hls @ 0000000000338ec0] Opening 'L:\A.S.OnGoing\0-NEW\CRD-Temp-File-KdJIgdWZTQeDUMUO\CRD-Temp-File-WDTQgDPdJMUQIUBF.key' for reading 23/04/24 12:26:34 [hls @ 0000000000338ec0] Unable to open key file L:\A.S.OnGoing\0-NEW\CRD-Temp-File-KdJIgdWZTQeDUMUO\CRD-Temp-File-WDTQgDPdJMUQIUBF.key 23/04/24 12:26:34 [hls @ 0000000000338ec0] Opening 'crypto:L:\A.S.OnGoing\0-NEW\CRD-Temp-File-KdJIgdWZTQeDUMUO\00000.ts' for reading 23/04/24 12:26:34 [crypto @ 000000000038ef40] Unable to open resource: L:\A.S.OnGoing\0-NEW\CRD-Temp-File-KdJIgdWZTQeDUMUO\00000.ts 23/04/24 12:26:34 [hls @ 0000000000338ec0] Failed to open segment 1 of playlist 0 23/04/24 12:26:34 [hls @ 0000000000338ec0] Opening 'crypto:L:\A.S.OnGoing\0-NEW\CRD-Temp-File-KdJIgdWZTQeDUMUO\00001.ts' for reading