search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
850 stars 109 forks source link

Default subtitle option does not work #955

Closed josedu2a closed 1 month ago

josedu2a commented 1 month ago

Describe the bug in version 3.23.2 the default subtitle option does not work. I did some tests downloading with different configurations and the default subtitle option does not work.

Where does the issue happen?

hama3254 commented 1 month ago

@josedu2a please add some context what you expect and what really happen. I take a loot at it within the next days.

hama3254 commented 1 month ago

@hmm-star please stay in your issues or make new ones for other problems, this helps me to keep track about the status more easily.

To answer your question, the latest version works fine but requires login details to get the required tokens. You can download all content the account is able to access this means a free account works fine for free anime but a premium account is required for premium episodes.

hama3254 commented 1 month ago

I did some tests downloading with different configurations and the default subtitle option does not work.

I am unable to reproduce the issue, mkv with copy and at least one softsubs selected allows to set the default subtile.

the ffmpeg command also looks totaly fine.

-allowed_extensions ALL -i "CRD-Temp-File-7ytrhebnxw8gn0yt.m3u8" -i "subs.txt" -map 0:v -map 0:a -map 1 -c copy -c:a copy -bsf:a aac_adtstoasc -c:s copy -metadata:s:s:0 language=ger -metadata:s:s:0 title="Deutsch" -metadata:s:s:0 handler_name="Deutsch" -disposition:s:0 default -metadata:s:a:0 language=eng