search

hama3254 / Crunchyroll-Downloader-v3.0

Downloader for Crunchyroll
850 stars 109 forks source link

Wrong sub format #984

Closed jorensanbar closed 3 weeks ago

jorensanbar commented 4 weeks ago

Describe the bug Option default: Download video + sub in SRT format.

Option Sub Only: Download correct sub in ASS format

The download process must be executed twice, since when the video is downloaded, the subtitles in ASS format are no longer included.

hama3254 commented 4 weeks ago

please add your settings, some may apply to video and subtitles but not subtitles only. i general the source files for the subtitles are the same for both modes since Option Sub Only only sets the video input to nothing and skips a view not applicable settings. https://github.com/hama3254/Crunchyroll-Downloader-v3.0/blob/588fc587f2e8c4682d540ba73baeb5d429d7573b/Crunchyroll%20Downloader/Main.vb#L1602 https://github.com/hama3254/Crunchyroll-Downloader-v3.0/blob/588fc587f2e8c4682d540ba73baeb5d429d7573b/Crunchyroll%20Downloader/Main.vb#L1603

jorensanbar commented 3 weeks ago

Fixed, changed setting Format MKV and SRT to Copy