Added french firstnames database generator

hamaluik / nomdebebe

A simple, private tool to help pick a baby name.

Apache License 2.0

265 stars 19 forks source link

Added french firstnames database generator #12

Closed blemasle closed 2 years ago

blemasle commented 2 years ago

This PR adds a script to generate a database based on France's Insee database for firstnames given from 1900 to 2019.

I replaced the original nomdebebe.db to test it locally, but it would obviously needs more work to be included in the app (user selectable database or a country field in the existing database maybe ?)

hamaluik commented 2 years ago

Awesome, thanks! I'll have to think about the best way to include multiple name sources.. it's something I never really considered but I've had a ton of requests for so some kajiggering is in order.

blemasle commented 2 years ago

You're welcome. We've been using the modified app for our own needs and it works really well, kudos 👏

As a heads up though, be aware that partner's list synchronization seems to suffer from character set issues (é, è ë Ï etc are broken). Not a huge deal at the moment and seems logical as you never intended the app for another character set. But if you include more data sets, you'll probably have to change how server are sent/stored/fetch to/from the server 🙂