search

hamaluik / timecop

A time tracking app that respects your privacy and the gets the job done without being fancy.
https://timecop.app/
Apache License 2.0
796 stars 149 forks source link

Added scrollability + fixed the issue of overflow - TimerEditor #133 #134

Open vpetrovic01 opened 7 months ago

vpetrovic01 commented 7 months ago

In the screen TimerEditor, scrollability has been added, and issue of overflow has been fixed. #133

overflow_fix

12people commented 7 months ago

Hi @vpetrovic01 Thanks for the PR!

Testing this out on macOS, I'm running into this issue: The following StateError was thrown building _SelectionKeepAlive(state: _SelectionKeepAliveState#0bede): Bad state: Stream has already been listened to..

To reproduce:

  1. Build under macOS (probably works for Linux too, or any platform where you can resize windows).
  2. Resize the window so that it's small enough to potentially contain only the timer description field.
  3. Visit a timer entry detail.
  4. Scroll down to the bottom of the screen.
  5. Scroll up.

(I'm thinking you can probably reproduce this error on Android or iOS by just adjusting the description box constraints — e.g. a minHeight of, say 600. I haven't tried it myself, though.)

Could you please fix this?

vpetrovic01 commented 7 months ago

Hi @12people, Thank you for your response, I fixed the issue and made a new pull request. Hope it works fine now!