search

hamano / openldap-pbkdf2

PBKDF2 for OpenLDAP
34 stars 7 forks source link

Adapt openldap-pbkfd2 module to use MozNSS #11

Closed azmagillian closed 6 years ago

azmagillian commented 6 years ago

Hi @hamano and community plz review and comment my proposed contribution. The applied changes introduce use of MozNSS library in order for an OpenLDAP configured with moznss option to be able to use openldap-pbkfd2 module!

azmagillian commented 6 years ago

One comment! I had to change my spec file in order to "make" the module after my changes. To be specific i had to add INCS+="-I../../../../include/nspr -I../../../../include -I../../../../servers/slapd". Should i commit this change also in the Makefile?

hamano commented 6 years ago

Thanks for your contribution! I'll review your code in a week.

azmagillian commented 6 years ago

I wiil test it locally to verify i didn't mess with the functionality! In the meantime plz continue your review !

hamano commented 6 years ago

NULL check is very important for authentication system, because it may become security hole.

azmagillian commented 6 years ago

OK all done! I will test it locally tomorrow. In the meantime plz continue your review !

azmagillian commented 6 years ago

Verified functionality too.