hamarituc / lbgpsdo

Configuration Utility for Leo Bodnar GPSDO
GNU General Public License v3.0
17 stars 8 forks source link

LIMIT_FOSC_MIN range check causing errors #2

Closed lff5 closed 1 year ago

lff5 commented 1 year ago

Hi Thanks for the lib. Works on OSX out of the box.

I have a little issue. I set up 10MHz config with the latest version of official GPS Clock Configuration app. Then I read it, store it locally, and try to activate by update and write.

clock = GPSDODevice.open()
config_10MHz = clock.read_config()
# stored here for testing
config_10MHz = {
    "out1": True,
    "out2": False,
    "level": 0,
    "fin": 1484375,
    "n3": 16,
    "n2_hs": 6,
    "n2_ls": 8192,
    "n1_hs": 4,
    "nc1_ls": 114,
    "nc2_ls": 114,
    "skew": 0,
    "bw": 9,
}
clock.update(**config_10MHz)
clock.write()

But This gets thrown: 'GPSDOConfigurationException fosc': 'Oscillator frequency is 4.800 GHz, but must be in the range of 4.85 GHz to 5.67 GHz.'

I think the error is in lbdgsdo.py LIMIT_FOSC_MIN = 4890000000 but it should be lower, e.g. LIMIT_FOSC_MIN = 4500000000

I saw your comment where the minimum originates. # according to table 26 in Si53xx family reference manual

But the original configuration software (v 1.17) by Leo is using lower fosc frequencies. E.g. try with 10 MHz:

gps_fosc

So Leo has approved it, I assume it is safe to use it below 4,89 GHz.