Make Unity2dPanel abstract - Githubissues

hamaxx / unity-2d-for-xmonad

Small changes to unity 2d that make using it with xmonad smoother

http://blog.hamsworld.net/2012/01/24/xmonad-on-ubuntu-11-10-oneiric-with-unity-2d/

GNU General Public License v3.0

16 stars 1 forks source link

Make Unity2dPanel abstract #10

Open koraa opened 12 years ago

koraa commented 12 years ago

Currently the Unity2dPanel class is designed for two cases:

The Launcher on the left (except when you are on a right to left system?!)
The panel on top The Launcher assumes that it is on the same monitor as the panel (inset staticly defined).

This imposes some problems:

It covers just two cases
Multiple monitors are hard This change is mostly an attempt to create a basis for #4.

Change to an abstract API with the following capabilities:

Can be on any side
Can be on any screen
Add signal when the screen disappears
Thickness is the same parameter for all sides
Add a dodge parameter for every side
Make the fallback redraw time dynamic
Make the fade-time dynamic
Remove Left to right code

Change the Panel code the following ways:

Make size set the size property (not height)
No leftmost prop any more required (we just have one panel)

koraa commented 12 years ago

Wow, there is already a panel on the right mode implemented...for right-to-left type systems