search

hamcrest / JavaHamcrest

Java (and original) version of Hamcrest
http://hamcrest.org/
BSD 3-Clause "New" or "Revised" License
2.11k stars 379 forks source link

IsUnmodifiableCollection matcher feature #249 #379

Open nhojpatrick opened 2 years ago

nhojpatrick commented 2 years ago

(cherry picked from commit 0ba3f59b81ca6c886a2064b993b6025f84bf9c57)

@Andremoniy could you take a look at this and this error https://github.com/hamcrest/JavaHamcrest/runs/5176851243?check_suite_focus=true as it's breaking once we bump source to java 1.8 and run on java 17, 18-ea or 19-ea.

Andremoniy commented 2 years ago

(cherry picked from commit 0ba3f59)

@Andremoniy could you take a look at this and this error https://github.com/hamcrest/JavaHamcrest/runs/5176851243?check_suite_focus=true as it's breaking once we bump source to java 1.8 and run on java 17, 18-ea or 19-ea.

Yes, I already noticed it and I am checking what can be done

Andremoniy commented 2 years ago

(cherry picked from commit 0ba3f59)

@Andremoniy could you take a look at this and this error https://github.com/hamcrest/JavaHamcrest/runs/5176851243?check_suite_focus=true as it's breaking once we bump source to java 1.8 and run on java 17, 18-ea or 19-ea.

Dear @nhojpatrick, I have addressed the issues in a new PR: https://github.com/hamcrest/JavaHamcrest/pull/381 Could you check it please?