Open rozagerardo opened 1 year ago
It would be nice if property descriptors would be supplemented with Class::getRecordComponents
in the case that Class::isRecord
is true
Is this still on the go? I strongly hope to see this happening. More and more people start using records for handler methods in spring boot.
@djkeh yes, I'm looking to do something to fix this in the next release.
I had a closer look at this issue. I don't think I can put a fix in for it right now. I'd like to keep the v3.x versions all compatible with Java 1.8. From v4.x, I will look to introduce features for more modern JVMs and runtime libraries.
Unfortunately, I don't have a timeline for how long it will take. I think there is a prerequisite for implementing JEP 238 support, which should give the forward/backward compatibility guarantees I think Hamcrest should support.
Describe the bug I have the following simple assertion in my test:
For the following record:
And even though I can see the object does have the property (set with a value), the test fails.
I have tracked this down, and it seems the "issue" is generated in the
PropertyUtil
class, in thepropertyDescriptorsFor
method:https://github.com/hamcrest/JavaHamcrest/blob/5d76642543b4d8c3e5f1b4cd4684d31be0724fde/hamcrest/src/main/java/org/hamcrest/beans/PropertyUtil.java#L49
This is what
Introspector.getBeanInfo(fromObj.getClass(), stopClass)
retrieves for a Record class:If I change the
AnyDto
to a regular class, the test passes, because the Introspector method above does containPropertyDescriptors
for the class:Note: the Record does contain
name
as aMethodDescriptor
, maybe we can rely on these for the Records?This is a related Stackoverflow Question: https://stackoverflow.com/questions/66982522/how-can-i-assert-hasproperty-with-a-java-record