hamcrest / JavaHamcrest

Java (and original) version of Hamcrest
http://hamcrest.org/
BSD 3-Clause "New" or "Revised" License
2.11k stars 376 forks source link

Fix licence and add correct SPDX licence identifier #414

Closed tumbarumba closed 1 month ago

tumbarumba commented 1 month ago

Closes #264, Closes #355, Closes #399

vlsi commented 1 month ago

Thanks for looking into this.

I'm afraid the PR does not fix the core of #264.

See the second clause of the license:

  1. Redistributions in binary form must reproduce the above copyright notice

Imagine somebody redistributes hamcreset.jar or includes it in their application. The license forces them to include the copyright notice, however, the release jars on Maven Central do not include the full license text. How would they know which exact license text (==copyright notice) matches every Hamcrest release?

See https://github.com/hamcrest/JavaHamcrest/pull/399/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R75-R77

The link https://opensource.org/license/BSD-3-Clause points to a license template rather than a canonical text. Please make the link point to the license text, and and please include the license text as META-INF/LICENSE to make it easier for the consumers to comply with the license.

tumbarumba commented 1 month ago

Thanks for looking at this @vlsi. I'll make the suggested changes in the next few days

tumbarumba commented 1 month ago

Fix merged. @vlsi, can you please check?