search

hamcrest / PyHamcrest

Hamcrest matchers for Python
http://hamcrest.org/
Other
766 stars 111 forks source link

wrong type annotation for IsDictContainingEntries.describe_keyvalue #182

Closed rittneje closed 2 years ago

rittneje commented 3 years ago

https://github.com/hamcrest/PyHamcrest/blob/498e031815312485cb9fb54a88291d3eb5735efd/src/hamcrest/library/collection/isdict_containingentries.py#L60-L62

Isn't the type of index (which should really have been named key) actually K, not int?

brunns commented 3 years ago

Good catch. Not too urgent an issue, mind you, since I can't see the describe_keyvalue() method being used other than internally by the class itself.