hamcrest / PyHamcrest

Hamcrest matchers for Python
http://hamcrest.org/
Other
766 stars 111 forks source link

Mark Python 3.12 as experimental for now. #231

Closed brunns closed 1 year ago

offbyone commented 1 year ago

Is this still needed now that the upstream is fixed?

brunns commented 1 year ago

Maybe not - but I am seeing breakage from Python 3.12 in other places - for example, due to https://github.com/python/cpython/issues/103329 - and it's possible we'll see more in future prereleases.

offbyone commented 1 year ago

I assume we'll want to know about that; is the idea that our CI would succeed but we'd notice a failing check? I'm not convinced :D

Can you make that conditional on it being a PR? I'm fine with the weekly check build sending us a nastygram if it's failing.

brunns commented 1 year ago

Sure, you're right - probably not worth bothering with now we don't have an upstream failure.