search

hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]
Other
6.96k stars 44 forks source link

Connect to Coveralls.Io #10

Closed aik099 closed 9 years ago

aik099 commented 10 years ago

It seems, that former https://github.com/cordoval/hamcrest-php had integration with Coveralls.Io service (presence of it's config indicates that).

How about to enable that integration for this repo as well (and remove old one) with adding corresponding badges to README.md?

cordoval commented 10 years ago

closed via fe0aca1cdb3905a05dd8efb7947fc332f57a298b

aik099 commented 10 years ago

Can you please also send coverage information to Scrutinizer, so it would affect code quality score?

Here is the instructions: https://scrutinizer-ci.com/docs/tools/external-code-coverage/

cordoval commented 10 years ago

reopening this due to last note

aik099 commented 9 years ago

@cordoval , was this done?

cordoval commented 9 years ago

I should do this, can you give me friday or do you want to go ahead and do this?

aik099 commented 9 years ago

can you give me friday

You mean you'll have time to do this on friday? Sure, no hurry.

cordoval commented 9 years ago

so it is configured https://coveralls.io/r/hamcrest/hamcrest-php the thing that we are missing is the https://scrutinizer-ci.com/docs/tools/external-code-coverage/ on it now

aik099 commented 9 years ago

Ah, so the Coveralls.Io integration was there, but we're not posting Coverage Report back to Scrutinizer CI. I see.

That's quite easy to configure but requires changes from both Scrutinizer CI side (to enable external code coverage) and repo side (Travis CI config to send that coverage).

The actual coverage is already being collected for Coveralls.Io.

cordoval commented 9 years ago

i have sent scrutinizer support message to see why this is not working cc @schmittjoh

cordoval commented 9 years ago

badge is green now https://scrutinizer-ci.com/g/hamcrest/hamcrest-php/?branch=master