Solving coding standard violations (solved: 3528, left: 147)

aik099 commented 10 years ago

Violations solved:

2852 violations related to 2 spaces indentation
5 violations related to parent class name was on new line
116 violations related new line after last method class
197 violations related wrong function declaration indentation
229 violations related wrong function call indentation
129 violations in generator

Related to: #11

The majority left issues are in fact usage of _ to indicate private class attribute/method. I personally use this, but it seems that PSR2 strictly forbids this.

@cordoval , should we fix that _ as well?

coveralls commented 10 years ago

Coverage remained the same when pulling 06565a632e7db2d9dd2be475ff9049d9a75ec677 on aik099:psr2-voilations-fix into fe0aca1cdb3905a05dd8efb7947fc332f57a298b on hamcrest:master.

coveralls commented 10 years ago

Coverage decreased (-0.19%) when pulling 0d4edd309cf2b6f9b2d105ab3c6f4ec50a47a383 on aik099:psr2-voilations-fix into fe0aca1cdb3905a05dd8efb7947fc332f57a298b on hamcrest:master.

cordoval commented 10 years ago

@aik099 we should also fix the `_``

cordoval commented 10 years ago

merging this we can do the _ in next PR

hamcrest / hamcrest-php

Solving coding standard violations (solved: 3528, left: 147) #14