hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]
Other
6.95k stars 44 forks source link

Load non-namespaced functions only if previously unloaded #21

Closed padraic closed 9 years ago

padraic commented 9 years ago

Checks if one of the more unique functions is previously defined. If not, will try to load all of the functions. This should help with hamcrest loading cross-project boundaries. Won't check all functions so clashes can still occur with non-hamcrest code (which is likely okay to leave alone).

aik099 commented 9 years ago

The Hamcrest.php file is generated. Please instead:

  1. add return statement to the generator/parts/assertThat.txt file (when function assertThat exit then don't do the rest)
  2. run php generator/run.php
  3. what's changed goes to PR

I advise to use Hamcrest\Matchers static class instead of global functions.

cordoval commented 9 years ago

ping @aik099 is this still needed? if yes it needs a rebase

aik099 commented 9 years ago

This is no longer needed after #22.