search

hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]
Other
6.95k stars 44 forks source link

Adding PHP 5.5, 5.6 and HHVM to Travis. #27

Closed h4cc closed 9 years ago

h4cc commented 9 years ago

HHVM is failing with:

There was 1 error:

1) Hamcrest\Arrays\IsArrayContainingInOrderTest::testMismatchesItemsInAnyOrder

Argument 1 passed to Hamcrest\NullDescription::appendDescriptionOf() must implement interface Hamcrest\SelfDescribing, bool given

/home/travis/build/hamcrest/hamcrest-php/hamcrest/Hamcrest/NullDescription.php:22

/home/travis/build/hamcrest/hamcrest-php/hamcrest/Hamcrest/Arrays/SeriesMatchingOnce.php:35

/home/travis/build/hamcrest/hamcrest-php/hamcrest/Hamcrest/Arrays/IsArrayContainingInOrder.php:38

/home/travis/build/hamcrest/hamcrest-php/hamcrest/Hamcrest/TypeSafeDiagnosingMatcher.php:14

/home/travis/build/hamcrest/hamcrest-php/hamcrest/Hamcrest/TypeSafeMatcher.php:47

/home/travis/build/hamcrest/hamcrest-php/tests/Hamcrest/AbstractMatcherTest.php:38

/home/travis/build/hamcrest/hamcrest-php/tests/Hamcrest/Array/IsArrayContainingInOrderTest.php:39
aik099 commented 9 years ago
  1. This might at as well be a bug in HHVM. Can you please debug it a bit?
  2. What about PHP7, can you please add it as well?

Once/if HHVM passes we can add badge from http://hhvm.h4cc.de/ as well.

h4cc commented 9 years ago
  1. Will have a look.
  2. PHP7 is currently just a alias to nightlyon travis: http://docs.travis-ci.com/user/languages/php/#PHP-7

Yeah, badges! :rocket:

aik099 commented 9 years ago

PHP7 is currently just a alias to nightlyon travis: http://docs.travis-ci.com/user/languages/php/#PHP-7

That's fine. Please just add it anyway. Most of the stuff already works on PHP7. I've just added 7 as version to Travis to use it.

h4cc commented 9 years ago

Looks good now :shipit:

h4cc commented 9 years ago

Reverted all PHP code changes. Kept changes for travis.

I cant work on HHVM integration currently :(

aik099 commented 9 years ago

You can come back any time to continue submission of failing tests. I'm in no hurry. :wink:

h4cc commented 9 years ago

So, HHVM and PHP 7.0 fail on travis - waiting to be fixed :hourglass:

This can be merged now.

aik099 commented 9 years ago

You haven't added a test, though I asked about it a few times, to prove that there is an issue in a way how current is used.

h4cc commented 9 years ago

I have not intended to make hamcrest HHVM compatible, just wanted to modify the builds so it gets clear if it works or not. Using allowed_failure builds now enables working on the problem we found.

Fixing the potential bug we found can be referred to someone else, i honestly dont know how to fix that end-to-end.

aik099 commented 9 years ago

I see. Then please submit a separate issue regardless the issue with SeriesMatchingOnce::isFinished method and I'll merge this PR.

aik099 commented 9 years ago

Thanks @h4cc , merging.