search

hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]
Other
6.95k stars 44 forks source link

Adding scrutinizer #29

Closed spekulatius closed 8 years ago

aik099 commented 8 years ago

We already have a config defined on Scrutinizer website. Can add these options there instead.

spekulatius commented 8 years ago

Hello @aik099

thanks for your response. If you define the configuration on the Scrutinizer website it only applies to your repository while a file would apply for all forks as well.

Spek

aik099 commented 8 years ago

It will apply for all PRs as well. Not sure why you need it to run on a fork.

davedevelopment commented 8 years ago

:+1: from me

aik099 commented 8 years ago

I've added changes to the repo config file on Scrutinizer CI website and executed the inspection with new config: https://scrutinizer-ci.com/g/hamcrest/hamcrest-php/inspections/ecb5376f-7740-4e83-9d93-9383d57d1385 . Due strange logic in Scrutinuzer CI you can't rerun inspection that needs external code coverage.

aik099 commented 8 years ago

@spekulatius , thanks for your contribution.