Prevent imcompatibilities in the future with new versions of php

hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]

Other

6.96k stars 44 forks source link

Prevent imcompatibilities in the future with new versions of php #31

Closed mikeSimonson closed 8 years ago

aik099 commented 8 years ago

Build fails.

davedevelopment commented 8 years ago

:+1:

@aik099 only because of a third party lib requiring a higher version of PHP? Probably affects the master branch and could be handled in a separate issue.

aik099 commented 8 years ago

I've sent #33 to solve this. If build passes in there, then I guess we need to:

merge it
rebase this PR against master to make builds pass

mikeSimonson commented 8 years ago

@aik099 fixed

aik099 commented 8 years ago

@mikeSimonson , you do read other comments, like one where I agreed with @davedevelopment to make this a separate PR and sent it, right?

mikeSimonson commented 8 years ago

I had already sent the fix before to see the other comment. Sorry

aik099 commented 8 years ago

That's ok. Please rollback last change then.

aik099 commented 8 years ago

Please rebase, because a fix has been committed to fix Composer error, that is happening.

mikeSimonson commented 8 years ago

@aik099 it's done.

aik099 commented 8 years ago

Looks good. Merging. Thanks @mikeSimonson .