Removing php 7 from the allowed failure

[aik099]

Please rebase, because a fix has been committed to fix Composer error, that is happening.

[mikeSimonson]

@aik099 done

[aik099]

I see more changes, than noted in PR description. What are they about?

• is_hexdecimal method
• removing PHP 5.3 and PHP 5.4 from Travis builds
• setting minimal allowed PHP version to PHP 5.4

The PR must stay on topic.

[mikeSimonson]

@aik099 After all the changes you proposed there are 2 issues left.

• It needs the is_string otherwise it fail when it can't cast to string (object without toString).
• And the last issue is to decide if you want to consider the case "0x" as a valid representation of 0 in hexadecimal or not ?

[aik099]

It needs the is_string otherwise it fail when it can't cast to string (object without toString).

OK.

And the last issue is to decide if you want to consider the case "0x" as a valid representation of 0 in hexadecimal or not ?

If it's valid in PHP, then it is for this library as well. I wrote this in the relevant test case.

[aik099]

Today’s review completed.

[aik099]

@mikeSimonson , please reply to each inline comment (also from outdated diffs) to indicate if that was fixed or not.

Since GitHub doesn't send notifications on new commits I also can't review your changes unless you add a comment to the issue about that.

[mikeSimonson]

Unless I missed something it should be done. @aik099

[aik099]

Looks good, except few CS issues I've described above.

Please also squash and rebase.

[mikeSimonson]

@aik099 Done

[mikeSimonson]

@aik099 re done

[aik099]

Merging. Thanks @mikeSimonson .

[aik099]

@davedevelopment , this PR is merged. You can make a 2.0.0 version release when you're ready.