search

hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]
Other
6.95k stars 44 forks source link

Use stable version of "satooshi/php-coveralls" library #33

Closed aik099 closed 8 years ago

aik099 commented 8 years ago
  1. the satooshi/php-coveralls library changed minimal required PHP version to 5.5 and therefore all our builds that use smaller PHP version fail due Composer (see https://travis-ci.org/hamcrest/hamcrest-php/jobs/100685661)
  2. added composer.lock file (good practice for libraries to have it in repo)
davedevelopment commented 8 years ago

:-1: for composer.lock, especially while the travis build runs composer install.

aik099 commented 8 years ago

Ah, that my mistake (when I initially created the .travis.yml file). It should be doing - composer update --prefer-source instead to test against latest dependency versions no matter what. The composer.lock file is for developers who really do composer install.

aik099 commented 8 years ago

@davedevelopment , now it's ok to merge?

davedevelopment commented 8 years ago

Yep!