Add FileMatchers - Githubissues

hamcrest / hamcrest-php

PHP Hamcrest implementation [Official]

Other

6.95k stars 44 forks source link

Add FileMatchers #71

Open vasekbrychta opened 3 years ago

vasekbrychta commented 3 years ago

Would it be possible to add FileMatchers?

aik099 commented 3 years ago

Sure. Please send a PR.

If you've found any more inconsistencies between the Java library version and this PHP port, then please open corresponding issues/PRs for adding missing stuff.

vasekbrychta commented 3 years ago

Ok, I'll prepare the PR.

vasekbrychta commented 3 years ago

Would you prefer the file matchers to match string paths, SplFileInfo objects or both?

aik099 commented 3 years ago

@vasekbrychta , both:

if string is provided it's wrapped into SplFileInfo class
if SplFileInfo object is provided, then it's used as is

For reference: https://github.com/hamcrest/JavaHamcrest/blob/master/hamcrest/src/main/java/org/hamcrest/io/FileMatchers.java