Remove show() to make package usable in terminal environments

hamedR96 / ANTM

Aligned Neural Topic Model (ANTM) for Exploring Evolving Topics: a dynamic neural topic model that uses document embeddings (data2vec) to compute clusters of semantically similar documents at different periods, and aligns document clusters to represent topic evolution.

MIT License

33 stars 7 forks source link

Remove show() to make package usable in terminal environments #4

Closed benearnthof closed 11 months ago

benearnthof commented 1 year ago

Hello, thanks for this awesome package! I've gone ahead and removed the calls to "show" for the figures that are being generated in the model.fit() method since the plots are saved anyway. The call to show would cause terminal sessions via ssh to get stuck in "HTTP request sent. Waiting for response." Because plotly renders pages in html which cannot be opened directly in a terminal. This is pure quality of life though, but I thought you may consider this pull request anyway. Thanks

hamedR96 commented 11 months ago

Thank you for your comments. I did some general changes in code. For the 3D figure, I defined a boolean so that you can control it.