search

hameerabbasi / xsparse

XSparse is an experimental XTensor-like C++ sparse-array library.
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Add Level properties #10

Closed bharath2438 closed 2 years ago

bharath2438 commented 2 years ago

@hameerabbasi I've added the base classes for properties with each level inheriting their properties (optional ones too for now).

hameerabbasi commented 2 years ago

One general comment: You have added the true variants, but every level needs to inherit from ALL level properties, either true or false. If it is configurable (indicated in the OOPSLA paper by a check mark inside square brackets), add a template parameter to the level and inherit based on that.

bharath2438 commented 2 years ago

One general comment: You have added the true variants, but every level needs to inherit from ALL level properties, either true or false. If it is configurable (indicated in the OOPSLA paper by a check mark inside square brackets), add a template parameter to the level and inherit based on that.

So, for the (✓) properties, can I take a template parameter like bool is_unique which would be used when inheriting from level_properties? We will need to then pass this bool during the creation of a level.

hameerabbasi commented 2 years ago

So, for the (✓) properties, can I take a template parameter like bool is_unique which would be used when inheriting from level_properties? We will need to then pass this bool during the creation of a level.

That's correct, you will need an extra template parameter.