search

hameerabbasi / xsparse

XSparse is an experimental XTensor-like C++ sparse-array library.
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

added hashed level + tests #6

Closed bharath2438 closed 2 years ago

bharath2438 commented 2 years ago

@hameerabbasi I have added all the functions of hashed level along with a base test case. As for the locate test case, I wasn't sure of the format of the loop, so I'll implement it after discussion although the locate function works.

hameerabbasi commented 2 years ago

Could you add some tests of mixing it with other levels?

bharath2438 commented 2 years ago

Could you add some tests of mixing it with other levels?

I've added four combinations of hashed level with other levels

bharath2438 commented 2 years ago

I misunderstood you question about size, yes we do need it.

Done.

hameerabbasi commented 2 years ago

@bharath2438 Seems CI didn’t trigger, can you push an empty commit to force it?

bharath2438 commented 2 years ago

@bharath2438 Seems CI didn’t trigger, can you push an empty commit to force it?

yeah sure, will do

hameerabbasi commented 2 years ago

Thanks, @bharath2438!

bharath2438 commented 2 years ago

Thanks a lot! Any reason why only the style check is happening?

hameerabbasi commented 2 years ago

See #7.