search

hamid0740 / JobUI

This is an advanced version of EconomyJob including a UI
https://poggit.pmmp.io/p/JobUI
Apache License 2.0
11 stars 4 forks source link

Fixed Crashes, and bug #18

Closed ErikPDev closed 3 years ago

ErikPDev commented 3 years ago

This commit should fix bugs mentioned on #16 This also fixes a bug that gives you reward even if it was canceled.

hamid0740 commented 3 years ago

Hello dear @ErikPDev and thanks for ur commitment Would u plz explain about the change on the priority u have done?

ErikPDev commented 3 years ago

I've set the priority highest to check if the event has been canceled, so the player won't get rewards when OnBlockBroken has been broken.

hamid0740 commented 3 years ago

Oh thanks Btw I may check it in a test server to make sure if it works or not

ErikPDev commented 3 years ago

Returned the event if player is creative.

ErikPDev commented 3 years ago

I've tested the code, and another server owner. It works =D

hamid0740 commented 3 years ago

I've tested the code, and another server owner. It works =D

Thanks my friend, I will check the code by the arrival of my test server and finally update the plugin 😉

hamid0740 commented 3 years ago

Returned the event if player is creative.

Good but u see, some people who buy the ranks with the ability of changing game mode, sometimes wanna mine to have easy income, so I think this one is not related to the plugin writer, but related to the server owner.

ErikPDev commented 3 years ago

Sorry! The same problem still exists. I don't think it's just the fact of the priority change. The fixed, could collide with a series of plugins that prevent its natural functioning. What causes the error "Trying to access the offset of the array on a value of type bool"

Have you tried the source from this branch? Hamid haven’t merged this pr with the master.