hamidhtc / h2database

Automatically exported from code.google.com/p/h2database
0 stars 0 forks source link

Support for modulus operator #292

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi

I wrote the code, it's mine, and I'm contributing it to H2 for distribution 
multiple-licensed under the H2 License,
version 1.0, and under the Eclipse Public License, version 1.0 
(http://h2database.com/html/license.html).

The only thing I'm not sure about in this patch is the errorcode I chose. A 
quick google search didn't turn up anything
close enough, so I picked an available number.

Original issue reported on code.google.com by noelgrandin on 2 Mar 2011 at 7:55

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,

Thanks a lot for the great patch! Do you want to commit it yourself? If yes I 
will add you as a committer. I changed a few smaller things however (see 
attachment):

- use 'division by zero' instead of adding a new error code (other databases, 
and Java, do the same)

- added to the help.csv (this will also upgrade the railroad diagrams

- documentation: removed from the roadmap, added to the change log

- removed "this." 

- removed "@Override" (I will add those at some point, but not yet)

- added the new words (your name ;-) to the dictionary.txt (./build.sh 
spellcheck)

Original comment by thomas.t...@gmail.com on 4 Mar 2011 at 3:54

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks Thomas, I would be happy to commit it myself. 
Let me know what style I should use for the commit message.

Original comment by noelgrandin on 4 Mar 2011 at 3:59

GoogleCodeExporter commented 9 years ago
The best commit message is what was added to the change log / the issue # and 
text:

Issue 292: Support for modulus operator

Original comment by thomas.t...@gmail.com on 4 Mar 2011 at 4:28

GoogleCodeExporter commented 9 years ago
Fixed in revision 3486

Original comment by noelgrandin on 7 Mar 2011 at 8:07