hamidra / dotdrop

Send dots as gifts to anyone and invite them to join polkadot
https://hamidra.github.io/dotdrop
The Unlicense
21 stars 12 forks source link

Adding a chain to gifts #188

Open decentration opened 1 year ago

decentration commented 1 year ago

This is fabulous dapp, probably the most underated thing in the whole of the ecosystem!

I am configuring this dapp so it takes the kabocha parachain. I have a couple questions.

1)

The connecting node should include the gift pallet in order to be able to issue gift vouchers Does this require the gift pallet? It seems like a gift pallet is not needed. Please could you clarify.

2) TypeError: Cannot read properties of undefined (reading 'batchAll') I'm getting the above error because our parachain does not currently have the utility pallet, do we need the utility pallet in order to use this?

hamidra commented 1 year ago

Thanks.

The connecting node should include the gift pallet in order to be able to issue gift vouchers Does this require the gift pallet? It seems like a gift pallet is not needed. Please could you clarify.

The app does not need the gift pallet. The mentioned of the gift pallet are from the earlier version of the app, but eventually we noticed there is no need for an extra pallet, and the current balances pallet provides all needed functionality.

TypeError: Cannot read properties of undefined (reading 'batchAll') I'm getting the above error because our parachain does not currently have the utility pallet, do we need the utility pallet in order to use this?

Yes, it currently uses batch transactions but We should be able to make it configurable if that helps to utilize it in more chains. I'll check to see if we can make it configurable.

decentration commented 1 year ago

That's great im having a look to see if batchAll is required. Will let you know how i do.

Also when i yarn build i get this error:

Failed to compile.

Failed to minify the code from this file: 

        webpack://./node_modules/@polkadot/types-codec/base/DoNotConstruct.js:28:15 

Read more here: https://cra.link/failed-to-minify
hamidra commented 1 year ago

There were some issues with some of the dependency versions in the yarn.lock, due to the latest changes. The changes with the corrupt lock file was reverted and the error should be fixed. Pls verify and let me know if you still see the error.

decentration commented 1 year ago

hey hamid, it now builds : )