search

hamiller / tracker-search-provider

Gnome-shell extension: displays tracker search results in the shell overview
16 stars 13 forks source link

Use MAX_RESULTS constant to display the right number of results #11

Closed Trim closed 9 years ago

Trim commented 9 years ago

So we are sure to display the asked number of results.

Should we use the minimal value between the max function argument and MAX_RESULTS ?

I didn't find any documentation here: https://developer.gnome.org/shell/stable/gdbus-org.gnome.Shell.SearchProvider2.html about that function.

googol42 commented 9 years ago

@Trim As not much is happening here, I am thinking about forking. In fact, I already created a fork, but I am not sure how much time I'll invest (=publishing it). But maybe you wanna work with me?

hamiller commented 9 years ago

Since MAX_RESULTS is hard coded at the start of the file, you're right, use it

Trim commented 9 years ago

@googol42 Sorry, but finally I've found more interesting for my needs to work directly on the tracker-needle code, so I don't think I'll continue to hack this plugin.

@hamiller thanks for the merge, but at least one question is still present: do you know what means the 'max' argument of this function ?