search

hamiltop / rethinkdb-elixir

Rethinkdb client in pure elixir (JSON protocol)
MIT License
497 stars 64 forks source link

Upgrade Poison #137

Closed gogocurtis closed 7 years ago

gogocurtis commented 7 years ago

Poison 3.1 is out.. is there any reason to have the version pinned at 1.5 or 2?

rschooley commented 7 years ago

This causes an issue when getting deps:

Running dependency resolution...

Failed to use "poison" because
  ecto (version 2.1.6) requires ~> 2.2 or ~> 3.0
  rethinkdb (version 0.4.0) requires ~> 1.5 or ~> 2.0
  mix.lock specifies 3.1.0

I will open a PR updating these instead of mucking around with old allowing versions of dependencies in my project.

edwinallenz commented 7 years ago

@gogocurtis do you have any issues updating Posion, I'm facing the same problem

gogocurtis commented 7 years ago

@edwinallenz I switched to Poison 2.0 as there was nothing specific about 3.1 that I needed - I mostly wanted to try out this driver and try the query lang and see how fast I could load the db.

the patch @rschooley Rschooley put in for a pull request should solve the issue, one could use his github branch as the package location via :github key in mix deps or @hamiltop may have other thoughts.

edwinallenz commented 7 years ago

thanks for the update update

gogocurtis commented 7 years ago

<3

edwinallenz commented 7 years ago

@hamiltop it's posible to tag this merge?