search

hamiltop / rethinkdb-elixir

Rethinkdb client in pure elixir (JSON protocol)
MIT License
497 stars 64 forks source link

Overhaul #145

Open vaartis opened 6 years ago

vaartis commented 6 years ago

I'm not sure if this library is dead or not, but i've done some oberhauling on it, it should fix most of the warnings and make tests pass (except the 2 i didn't figure out how to fix)

norpan commented 6 years ago

Elixir 1.6 needs OTP 19 or higher. I made a pull request #146 to test all Elixir/OTP compatible versions from 1.3 and upwards. You could merge that and see what happens.

vaartis commented 6 years ago

I dunno, they fail locally too, with OTP 20

norpan commented 6 years ago

The ssl test fails because of a bad certificate, and should be removed. The other test that fails does not fail if I replace the test file with the one from master, so it's something in the test itself. I see that you have changed the test to create and remove the test database, perhaps that has something to do with it?

vaartis commented 6 years ago

I don't really have time to work on it now..

norpan commented 6 years ago

I can make a new version of this on top of the current master, if you don't have time. Maybe we should fix one thing at a time.

vaartis commented 6 years ago

Please do make a new one then

norpan commented 6 years ago

We should probably also use the new "mix format" to make merging easier in the future. I'll make a list of things to fix in a new issue and then we can tick them off.

vaartis commented 6 years ago

Fixed conflects there were there and rebased on master. Tests should pass i think.

vaartis commented 6 years ago

Im not sure how geospatial tests work but they fail..