search

hamishcampbell / silverstripe-auth-external

SilverStripe External Authentication Module
13 stars 21 forks source link

Cannot access private property Security::$autologin_enabled #20

Open blpraveen opened 10 years ago

blpraveen commented 10 years ago

Getting this error when I install on 3.1 Silverstripe Version

Realys-31 commented 9 years ago

Me too... i use SS v3.1.8

Realys-31 commented 9 years ago

Quickly... I have comment line 72 to 79 in "code/ExternalLoginForm.php" : / if(Security::$autologin_enabled) { $fields->push(new CheckboxField( "Remember", _t('ExternalAuthenticator.Remember','Remember me next time?'), Session::get('SessionForms.ExternalLoginForm.Remember'), $this )); } /

It's ok now ! So there is no remember me checkbox... Not important for test. ++

svandragt commented 9 years ago

If you replace line 72 with if (Security::config()->autologin_enabled) { then it will probably work without having to comment out the code.

Amenel commented 8 years ago

@svandragt Rewriting that line as you wrote it does the trick! But we are modifying external modules. Sub-optimal I guess, unless this has been superseded (as the official repo for the auth-external module) by a fork? I see that you were the last modifier on this repo. Any chance that the correct line gets into the master branch? I guess that will also require bumping the compatibility listed in the requirements to SilverStripe 3.1.

svandragt commented 8 years ago

This module is in need of some maintenance. I am no longer using SilverStripe at work as I switched jobs so it's more difficult to make time to do a 3.1 compatible review but I would accept pull requests.

Sander

On 16 Jul 2016, 17:20 +0100, Amenelnotifications@github.com, wrote:

@svandragt(https://github.com/svandragt)Rewriting that line as you wrote it does the trick! But we are modifying external modules. Sub-optimal I guess, unless this has been superseded (as the official repo for the auth-external module) by a fork? I see that you were the last modifier on this repo. Any chance that the correct line gets into the master branch? I guess that will also require bumping the compatibility listed in the requirements to SilverStripe 3.1.

— You are receiving this because you were mentioned. Reply to this email directly,view it on GitHub(https://github.com/hamishcampbell/silverstripe-auth-external/issues/20#issuecomment-233138005), ormute the thread(https://github.com/notifications/unsubscribe-auth/AAkTt2IG-KBDiwsOwuGA-ByAMgede1czks5qWQTbgaJpZM4CsP0I).