hamishcoleman / thinkpad-ec

Infrastructure for examining and patching Thinkpad embedded controller firmware
GNU General Public License v2.0
1.06k stars 113 forks source link

Couldn't managed to have 29++ working on my x230 #126

Open tberkayb opened 5 years ago

tberkayb commented 5 years ago

I have done all the exact things in the read me file. (I changed the .OFF parts, just left the battery patch w/o OFF)

before patch in linux the battery info was shown (design power, brand etc.) but not charging after the patch all battery info missing. The message is: "~$ upower -i /org/freedesktop/UPower/devices/battery_BAT0 native-path: BAT0 power supply: yes updated: Sat 18 May 2019 01:06:43 EEST (97 seconds ago) has history: yes has statistics: yes battery present: yes rechargeable: yes state: charging warning-level: none energy: 0 Wh energy-empty: 0 Wh energy-full: 0 Wh energy-full-design: 0 Wh energy-rate: 0 W percentage: 0% capacity: 100% icon-name: 'battery-caution-charging-symbolic' "

hamishcoleman commented 5 years ago

The battery information should not have changed - this indicates some other problem.

The only thing that the patch changes is the result of the check for an original battery. I dont know any reason why you would have started seeing this immediately after patching.

Have you tried reverting the patch?

tberkayb commented 5 years ago

Thank you for your answer!

I tried it but it did nothing :(

31 Tem 2019 Çar, saat 12:04 tarihinde Hamish Coleman < notifications@github.com> şunu yazdı:

The battery information should not have changed - this indicates some other problem.

The only thing that the patch changes is the result of the check for an original battery. I dont know any reason why you would have started seeing this immediately after patching.

Have you tried reverting the patch?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hamishcoleman/thinkpad-ec/issues/126?email_source=notifications&email_token=AMDGD5DWJPJ7RHXLR345EBTQCFIRNA5CNFSM4HNYZTF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3GTBVQ#issuecomment-516763862, or mute the thread https://github.com/notifications/unsubscribe-auth/AMDGD5DI5VNMXAADZSB6HVTQCFIRNANCNFSM4HNYZTFQ .

-- Tegin Berkay Budak Istanbul Technical University Astronautical Engineering Undergraduate Student Pars Rocketry Mechanics Team Member

İletişim: E-mail: teginberkaybudak@p teginberkaybudak@gmail.comarsroket.com http://arsroket.com E-mail: teginberkaybudak@gmail.com teginberkaybudak@hotmail.com Gsm: +905337238869

hamishcoleman commented 5 years ago

Unfortunately, it sounds like something is actually wrong with your battery hardware. I have not heard from anyone else about any issue like this with their patches - so I am assuming that it is just bad timing and unrelated to the patch

tberkayb commented 5 years ago

hello there,

I think i was a little bit unlucky :/. Thank you for your contribution to the thinkpad community!

Best Regards

Hamish Coleman notifications@github.com, 6 Ağu 2019 Sal, 18:48 tarihinde şunu yazdı:

Unfortunately, it sounds like something is actually wrong with your battery hardware. I have not heard from anyone else about any issue like this with their patches - so I am assuming that it is just bad timing and unrelated to the patch

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hamishcoleman/thinkpad-ec/issues/126?email_source=notifications&email_token=AMDGD5HLBM3WLYINR2WKJODQDGMMDA5CNFSM4HNYZTF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VSY2Q#issuecomment-518728810, or mute the thread https://github.com/notifications/unsubscribe-auth/AMDGD5FYYF35ZJBW4QBBNIDQDGMMDANCNFSM4HNYZTFQ .

-- Tegin Berkay Budak Istanbul Technical University Astronautical Engineering Undergraduate Student Pars Rocketry Mechanics Team Member

İletişim: E-mail: teginberkaybudak@p teginberkaybudak@gmail.comarsroket.com http://arsroket.com E-mail: teginberkaybudak@gmail.com teginberkaybudak@hotmail.com Gsm: +905337238869

kmeaw commented 5 years ago

I have reproduced the issue on my hardware.

kmeaw commented 5 years ago

Bought another battery - now everything works fine.