search

hamishcoleman / thinkpad-ec

Infrastructure for examining and patching Thinkpad embedded controller firmware
GNU General Public License v2.0
1.07k stars 115 forks source link

Update x230 to latest bios iso, no EC changes #16

Closed evq closed 7 years ago

evq commented 7 years ago

I accidentally backed myself into a corner by updating to the latest bios instead of the one which is used in this repo. I couldn't seem to find a way to downgrade so I attempted to upgrade the iso which is specified here. Looks like there weren't any EC changes as no hashes changed besides the iso.

I seemed to get a successful build out and was able to disable battery validation on my x230. Anyway, I have no idea what I'm doing (read: I'm hesitant to suggest merging this) but I wanted to make this available in case someone makes the same mistake!

hamishcoleman commented 7 years ago

Hi there!, Thanks for your changes. It all looks reasonably fine to me - so you cannot say you have no idea what you are doing :-) (seriously, that Makefile got a lot larger - and thus impenetrable - than I ever expected it to get, so you clearly have some idea of what you are doing)

Can I ask that you keep the old sha1 file as well as adding a new one?

Finally, it is the simplest correct thing for me to say "ensure you are running the newest BIOS" in the instructions, but the reality is a little more nuanced than that - you would only have painted yourself in a corner if the EC version had changed (and even then, I have been surprised at what mismatches seem to work by accident)