search

hamishcoleman / thinkpad-ec

Infrastructure for examining and patching Thinkpad embedded controller firmware
GNU General Public License v2.0
1.07k stars 115 forks source link

Configuration TODOs in Makefile #192

Closed nomuna closed 3 years ago

nomuna commented 3 years ago

Configuration edits the .config file instead of just appending to it.

Thanks for the tool. I have patched my X230 with it and noticed that the .config file was being appended to and not edited. I have also noticed the TODOs regarding this issue. Please have a look at it. Keep up the good work.

hamishcoleman commented 3 years ago

Thanks!

Just thinking about it - this is a little more fragile. The config vars may not be in the config file or the pattern might match a wrong thing. However, that shouldnt normally be an issue.