search

hamishcoleman / thinkpad-ec

Infrastructure for examining and patching Thinkpad embedded controller firmware
GNU General Public License v2.0
1.06k stars 115 forks source link

Battery patch not working on x230 #204

Open nathanstampfli opened 3 years ago

nathanstampfli commented 3 years ago

I've been trying to make the battery patch work on my Thinkpad x230. I've installed the firmware version (2.75 and 1.14). I used the command to enable the battery patch and disable the keyboard patch. No problem booting on the usb device, I get the message to flash the Embedded controller firmware, I press any key and it does flash. After that the laptop reboots and shows "Flashing Embedded Controller.... Please do not power off" and then reboots again by itself.

Unfortunately, when I go into Windows, I still can not charge my x220 battery. I flashed the laptop several times, with an original x230 battery inside, without any battery, using different power adapters and still no luck getting the battery charged.

Any suggestions to what I could do differently?

DWC147 commented 2 years ago

Same with me, X230. I tried all the combinations of the battery and keyboard commands in various orders to see if I could get the battery issue fixed but to no avail. If I set the battery option to "make patch_enable_battery clean", it would show just at the end of compiling that it was set, but if I used the "make patch_disable_battery clean" it didn't show any battery changes after compiling but did show the Keyboard changes which isn't the problem I'm fixing. In any event, it did not switch off the battery validation. I have flashed the BIOS to several different versions, and did use the 2.75 and EC 1.4. I think that its impossible to enable the battery patch. Perhaps it could be enabled by default and then it might work. Thanks for reading.

ghost commented 2 years ago

My suggestion is to make clean then make patch_enable_battery clean then compile the img.

Alternatively you can try to clone into a fresh folder and attempt again.

pavelselivanov commented 2 years ago

My suggestion is to make clean then make patch_enable_battery

Thanks! That worked for me! Battery patch wasn't enabled by default.

Also, by default make generates some keyboard patch that screws some keys on x230 like PgUp/Down etc. So I had to: make clean
make patch_disable_keyboard make patch_enable_battery

make patched.x230.img This way patched image allows battery charging and keyboard works fine.