search

hamishcoleman / thinkpad-ec

Infrastructure for examining and patching Thinkpad embedded controller firmware
GNU General Public License v2.0
1.04k stars 114 forks source link

Help Lenovo v580c #221

Closed deeptenk2 closed 1 year ago

deeptenk2 commented 1 year ago

Hello, my english is not very good, sorry. I need help, Lenovo V580c 20160, i need to disable the authentic battery validation check permanently. I once managed to do something similar with the t430, but I can't figure out how to build an iso image for a usb stick for the v580c. Can you help me with this? https://ibb.co/3Sw4xzD

deeptenk2 commented 1 year ago

missing 0 byte files in repo

leecher1337 commented 1 year ago

Notes to the maintainer: To be more specific: The 0 byte files in merged repository are there on purpose:

https://github.com/leecher1337/thinkpad-ec/tree/Lx30/b580.H1ET73WW.img.d https://github.com/leecher1337/thinkpad-ec/tree/Lx30/b590.H9ET92WW.img.d https://github.com/leecher1337/thinkpad-ec/tree/Lx30/e330.H3EC35WW.img.d https://github.com/leecher1337/thinkpad-ec/tree/Lx30/l430.G3HT40WW.img.d

Otherwise, the script bails out with an error not finding the appropriate patches, when not disabling Keyboard-Patch. Maybe readd the 0byte files or modify Makefile to ignore missing files, i.e. if user doesn't disable keyboard patches? (See: https://youtu.be/us6K5udvJbI )

Additionally, update documentation so that it ensures that innoextract gets installed (add it to apt-get install instructions or make build-deps)

hamishcoleman commented 1 year ago

@leecher1337 I removed the zero byte files because you cannot patch something that you cannot patch - if you try to patch the keyboard then it will fail because it cannot patch the keyboard.

You are right that the docs should have mentioned to install the innoextract

hamishcoleman commented 1 year ago

@deeptenk2 , it looks like you did not run any configure steps. At step 6, you should:

make patch_enable_battery patch_disable_keyboard clean

I have also updated the steps slightly to ensure you have the right packages installed - be sure to read the most recent README and follow the steps again

deeptenk2 commented 1 year ago

Yes thank you. I already figured it out. I'm a Windows sysadmin and don't know much about Linux.p.s. everything worked out and went well. 20.07.2022, 02:25, "Hamish Coleman" @.**@. , it looks like you did not run any configure steps. At step 6, you should:make patch_enable_battery patch_disable_keyboard clean —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>  -- С уважением,Святослав @. 

hamishcoleman commented 1 year ago

Good to hear! Thanks for letting me know.