search

hamishcoleman / thinkpad-ec

Infrastructure for examining and patching Thinkpad embedded controller firmware
GNU General Public License v2.0
1.07k stars 115 forks source link

proper tab in the laptop list in the Makefile #59

Open l29ah opened 6 years ago

hamishcoleman commented 6 years ago

What is the advantage of making this change?

On the flip side, writing it as "\t" means that even in editors where the difference between soft and hard tabs are unclear (which is most of them), it is still clear that you have written the right one.

(I also have to stop and comment on the irony of talking about tabs in a Makefile, which has its own love/hate relationship with tabs)

l29ah commented 6 years ago

It is displayed as \t otherwise, afair.

hamishcoleman commented 6 years ago

Ah, that is a little more annoying - it doesnt happen for me, so clearly different shell or make versions are at play here.

Can you try changing it to 'echo -e "$$i.img\t....."' ?

l29ah commented 6 years ago

GNU bash, version 4.4.12(1)-release (x86_64-pc-linux-gnu)

Yes, it works fine w/ -e.

hamishcoleman commented 6 years ago

I've pushed a change in 95b63fa943b5694b27c36480e718421988764e53 that should address this setting.

hamishcoleman commented 6 years ago

This problem with displaying things will probably have resurfaced as part of other work. Since it is a cosmetic display-only issue, I can live with that for the moment.

But - reopening to remind me to fix it better