search

hamishcunningham / fishy-wifi

Scripts, notes and the odd subaquatic gizmo for the ESP8266 and what-have-you.
GNU Affero General Public License v3.0
25 stars 13 forks source link

Add delay before initialising DHT22 #16

Closed cgmcintyr closed 6 years ago

cgmcintyr commented 6 years ago
layerzerolabs commented 6 years ago

I see BUILTIN_LED defined in .../Arduino/hardware/espressif/esp32/variants/feather_esp32/pins_arduino.h static const uint8_t LED_BUILTIN = 13; #define BUILTIN_LED LED_BUILTIN // backward compatibility I don't understand the value of (re?)defining this in the sketch?

cgmcintyr commented 6 years ago

Sorry, this may be to do with not including the Arduino/hardware/espressif/esp32/variants/feather_esp32/pins_arduino.h, I'll be sure to remove the definition of BUILTIN_LED from the pull request.

layerzerolabs commented 6 years ago

Ah yes, I remember you saying you were also using the expressif IDF - fundamentally better I'm sure but for us the main advantage of the arduino IDE is that novices can hack our stuff, widening up participation...

hamishcunningham commented 6 years ago

Happy to merge but pending discussion on #15 ...?