search

hamishcunningham / fishy-wifi

Scripts, notes and the odd subaquatic gizmo for the ESP8266 and what-have-you.
GNU Affero General Public License v3.0
25 stars 13 forks source link

Captive Portal and Joinme as a library #19

Closed Eroc33 closed 6 years ago

Eroc33 commented 6 years ago

This re-implements joinme as a library. The files for joinme have been moved into the waterelf32 project folder as this is the only easy way I could find mentioned online to use them as a library. Joinme currently isn't handling connecting to WiFi APs, but is handling captive portal (though this is currently untested for iPhone, but is confirmed working on android 7.1.1 (Android N) ).

(Joinme is currently using a c style interface but if you prefer i could convert it to use an object for a c++ style interface).

Eroc33 commented 6 years ago

I'm thinking that perhaps handle_wifi and handle_wfchz should also be handled be joinme instead of the main sketch? Also is this good how it is or should it be synchronous like the original lua joinme (where you have to join a wifi hotspot to get to the main program)

layerzerolabs commented 6 years ago

Good questions but to answer them I think we need to consider #8 refactoring - makes sense to refactor into a new design rather than do it twice...

On 18 Nov 2017 18:04, "Euan Rochester" notifications@github.com wrote:

I'm thinking that perhaps handle_wifi and handle_wfchz should also be handled be joinme instead of the main sketch? Also is this good how it is or should it be synchronous like the original lua joinme (where you have to join a wifi hotspot to get to the main program)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hamishcunningham/fishy-wifi/pull/19#issuecomment-345459543, or mute the thread https://github.com/notifications/unsubscribe-auth/AFFUF8Rm_QurS7fEFDZm51f-AncOTtfHks5s3xwQgaJpZM4QjDTN .

Eroc33 commented 6 years ago

Do you want me to open a new PR for the comment changes? or should I just push them to master?

hamishcunningham commented 6 years ago

Just push directly to master, tnx! h