search

hamishcunningham / fishy-wifi

Scripts, notes and the odd subaquatic gizmo for the ESP8266 and what-have-you.
GNU Affero General Public License v3.0
25 stars 13 forks source link

Reduced tsl2561 memory use #5

Closed Aeprox closed 9 years ago

Aeprox commented 9 years ago

Fix #4 Changed sensor integration time from 13.7 to 402ms Removed unneeded variables Reduced number of files Conforms to nodeMCU module syntax

hamishcunningham commented 9 years ago

hi, thanks for the code! one question: what do you mean my nodeMCU module syntax? has some decision been made about modules in nodeMCU? in Lua itself of course there are several module syntax options... cheers h

Aeprox commented 9 years ago

No no, thank YOU for the code!

Most (if not all) of the modules found in the lua_modules folder of the nodeMCU firmware seem to follow this synthax. It seemed a good idea to me to make it conform to the rest of the modules I use in my project. I remember reading somewhere that it also helps eLua keep memory use down, though I can't find where I read that bit of information at the moment.

(I also just noticed I accidentaly changed the TSL2561 integration time from 13.7ms to 402ms in my commit, please make note of that)

It's my first pull request so forgive my ignorance.

hamishcunningham commented 9 years ago

ok, cool, thanks I'll let gareth know about the timing issue best h

On 11 June 2015 at 23:01, Michael Lucas notifications@github.com wrote:

No no, thank YOU for the code!

Most (if not all) of the modules found in the lua_modules folder of the nodeMCU firmware seem to follow this synthax. It seemed a good idea to me to make it conform to the rest of the modules I use in my project. I remember reading somewhere that it also helps eLua keep memory use down, though I can't find where I read that bit of information at the moment.

(I also just noticed I accidentaly changed the TSL2561 integration time from 13.7ms to 402ms in my commit, please make note of that)

It's my first pull request so forgive my ignorance.

— Reply to this email directly or view it on GitHub https://github.com/hamishcunningham/fishy-wifi/pull/5#issuecomment-111287959 .

Hamish Cunningham Professor of Computer Science, University of Sheffield, UK +44 7920 765 455 https://twitter.com/@HCunningham hamish@gate.ac.uk https://pi.gate.ac.uk https://hamish.gate.ac.uk https://gate.ac.uk